From f0bcd97be3ea893407dae6251f84805d21557432 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Tue, 15 Jul 2008 21:16:32 +0000 Subject: [PATCH] Revert r37669: LinkerLinkAttributes hook doesn't seem to make a lot of sense. The parameters passed can't be modified, and they are escaped for output, making it unsuitable as a general extension hook. --- RELEASE-NOTES | 1 - docs/hooks.txt | 6 ------ includes/Linker.php | 1 - 3 files changed, 8 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 22e89c28b2..b33713bdb2 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -188,7 +188,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN the database is potentially queried * (bug 9736) Redirects on Special:Fewestrevisions are now marked as such. * New date/time formats in Cs localization according to ČSN and PČP. -* Added new hook LinkerLinkAttributes for modifying attributes of tags. * Add a new hook SkinSetupSiteCss to allow extensions to define new stylesheets to load site wide, or modify the list of stylesheets to load. This can be useful for wiki farms who need a specific placement of the stylesheets to cascade right. diff --git a/docs/hooks.txt b/docs/hooks.txt index bf9c694d0a..a8930cc1e0 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -753,12 +753,6 @@ $lang: laguage code (string) $specialPageAliases: associative array of magic words synonyms $lang: laguage code (string) -'LinkerLinkAttributes': At the end of Linker::getLinkAttributesInternal() just before the return -&$this: Linker object -$title: 'title' attribute string -$class: 'class' attribute string -&$result: Final attribute string - 'LinkerMakeExternalImage': At the end of Linker::makeExternalImage() just before the return &$url: the image url &$alt: the image's alt text diff --git a/includes/Linker.php b/includes/Linker.php index af5636d662..03e7a9eb22 100644 --- a/includes/Linker.php +++ b/includes/Linker.php @@ -108,7 +108,6 @@ class Linker { $r .= " class=\"$class\""; } $r .= " title=\"$title\""; - wfRunHooks( 'LinkerLinkAttributes', array( &$this, $title, $class, &$r ) ); return $r; } -- 2.20.1