From 3eb11888e97b11aeb6dc75a2376db2af28d24050 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Thu, 29 Jan 2015 20:54:06 +0100 Subject: [PATCH] Handle invalid grouppage on Special:Statistics Passing null to Linker::link gives warning on the side Change-Id: Ibee9eb039e88c23ba38ff6594f449316b22ecba6 --- includes/specials/SpecialStatistics.php | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/includes/specials/SpecialStatistics.php b/includes/specials/SpecialStatistics.php index 44290220ef..1f339d1ed0 100644 --- a/includes/specials/SpecialStatistics.php +++ b/includes/specials/SpecialStatistics.php @@ -199,10 +199,16 @@ class SpecialStatistics extends SpecialPage { $grouppageLocalized = $msg->text(); } $linkTarget = Title::newFromText( $grouppageLocalized ); - $grouppage = Linker::link( - $linkTarget, - htmlspecialchars( $groupnameLocalized ) - ); + + if ( $linkTarget ) { + $grouppage = Linker::link( + $linkTarget, + htmlspecialchars( $groupnameLocalized ) + ); + } else { + $grouppage = htmlspecialchars( $groupnameLocalized ); + } + $grouplink = Linker::linkKnown( SpecialPage::getTitleFor( 'Listusers' ), $this->msg( 'listgrouprights-members' )->escaped(), -- 2.20.1