From 2deb4722330ce6d8856cfa65282fdbe7e6238019 Mon Sep 17 00:00:00 2001 From: Matthew Flaschen Date: Fri, 5 Sep 2014 22:38:55 -0400 Subject: [PATCH] Sort modules in alphabetical order and leave note about this This ensures the rendering matches what would happen if they were used together with addModuleStyles, which is the way these modules are generally used. Change-Id: I1d6f0f41dc9ac4782a4c5891354b0e323a6161b5 --- docs/kss/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/kss/Makefile b/docs/kss/Makefile index ff735d5180..a7b0c47122 100644 --- a/docs/kss/Makefile +++ b/docs/kss/Makefile @@ -4,7 +4,9 @@ kss: kssnodecheck # Generates CSS of mediawiki.ui and mediawiki.ui.button using ResourceLoader, then applies it to the # KSS style guide $(eval KSS_RL_TMP := $(shell mktemp /tmp/tmp.XXXXXXXXXX)) - @curl -sG "${MEDIAWIKI_LOAD_URL}?modules=mediawiki.ui.anchor|mediawiki.ui.checkbox|mediawiki.ui.input|mediawiki.legacy.shared|mediawiki.legacy.commonPrint|mediawiki.ui|mediawiki.ui.button&only=styles" > $(KSS_RL_TMP) +# Keep module names in strict alphabetical order, so CSS loads in the same order as ResourceLoader's addModuleStyles does; this can affect rendering. +# See OutputPage::makeResourceLoaderLink. + @curl -sG "${MEDIAWIKI_LOAD_URL}?modules=mediawiki.legacy.commonPrint|mediawiki.legacy.shared|mediawiki.ui|mediawiki.ui.anchor|mediawiki.ui.button|mediawiki.ui.checkbox|mediawiki.ui.input&only=styles" > $(KSS_RL_TMP) @node_modules/.bin/kss-node ../../resources/src/mediawiki.ui static/ --css $(KSS_RL_TMP) -t styleguide-template @rm $(KSS_RL_TMP) -- 2.20.1