From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Tue, 10 Sep 2019 08:46:46 +0000 (+0200)
Subject: maintenance: Fix broken userOptions maintenance script
X-Git-Tag: 1.34.0-rc.0~289
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%20%22id_auteur=%24id%22%29%20.%20%22?a=commitdiff_plain;h=fa604c68e46821e32a0a4302598db87a6d15d840;p=lhc%2Fweb%2Fwiklou.git

maintenance: Fix broken userOptions maintenance script

Broken via I973cc60 just a few weeks ago.

Change-Id: I9e60b84acf6c2bf751e2e6cb8e97f0a7cba2764d
---

diff --git a/maintenance/userOptions.php b/maintenance/userOptions.php
index 98f1c24a86..2f8941f3da 100644
--- a/maintenance/userOptions.php
+++ b/maintenance/userOptions.php
@@ -110,11 +110,10 @@ The new option is NOT validated.' );
 					$ret[$option][$userValue] = ( $ret[$option][$userValue] ?? 0 ) + 1;
 				}
 			} else {
-
 				foreach ( $defaultOptions as $name => $defaultValue ) {
 					$userValue = $user->getOption( $name );
 					if ( $userValue != $defaultValue ) {
-						$ret[$option][$userValue] = ( $ret[$option][$userValue] ?? 0 ) + 1;
+						$ret[$name][$userValue] = ( $ret[$name][$userValue] ?? 0 ) + 1;
 					}
 				}
 			}