From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Fri, 18 Jul 2008 19:36:42 +0000 (+0000)
Subject: Accesskeys for minor edit/watch checkboxes on edit now work in Firefox 3.  It apparen... 
X-Git-Tag: 1.31.0-rc.0~46451
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%20%22id_auteur=%24id%22%29%20.%20%22?a=commitdiff_plain;h=bad08caf337b1b9162d034bf7fdb793bf46f88e9;p=lhc%2Fweb%2Fwiklou.git

Accesskeys for minor edit/watch checkboxes on edit now work in Firefox 3.  It apparently doesn't like an accesskey being declared for both an input element and its label.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 65e60dfe19..bc188db7f9 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -439,6 +439,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   history pages
 * (bug 14845) Bug in prefs javascript: Calling an array item without checking
   its existance.
+* Accesskeys for minor edit/watch checkboxes on edit now work in Firefox 3
 
 === API changes in 1.13 ===
 
diff --git a/includes/EditPage.php b/includes/EditPage.php
index d5a4383029..ce741a7211 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -1966,7 +1966,7 @@ END
 			);
 			$checkboxes['minor'] =
 				Xml::check( 'wpMinoredit', $checked['minor'], $attribs ) .
-				"&nbsp;<label for='wpMinoredit'".$skin->tooltipAndAccesskey('minoredit').">{$minorLabel}</label>";
+				"&nbsp;<label for='wpMinoredit'".$skin->tooltip('minoredit').">{$minorLabel}</label>";
 		}
 
 		$watchLabel = wfMsgExt('watchthis', array('parseinline'));
@@ -1979,7 +1979,7 @@ END
 			);
 			$checkboxes['watch'] =
 				Xml::check( 'wpWatchthis', $checked['watch'], $attribs ) .
-				"&nbsp;<label for='wpWatchthis'".$skin->tooltipAndAccesskey('watch').">{$watchLabel}</label>";
+				"&nbsp;<label for='wpWatchthis'".$skin->tooltip('watch').">{$watchLabel}</label>";
 		}
 		return $checkboxes;
 	}