From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Wed, 13 Feb 2019 13:21:04 +0000 (+0100)
Subject: resourceloader: Restore the comment about <script> vs XHR loading
X-Git-Tag: 1.34.0-rc.0~2826^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%20%22id_auteur=%24id%22%29%20.%20%22?a=commitdiff_plain;h=3d38db2a658cfd24848ab6204cb82614161428e0;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Restore the comment about <script> vs XHR loading

Removed in 42956b99b558294e5aa8c6c0e2a8f18513478022.

I think it's useful to know this rationale (even more so because
the arguments about caching seem no longer correct these days).

Also, add the line about loading progress not being known when
using this method.

(Slightly related to T216034)

Change-Id: I81fa90483c0c85fecc5cb620196521ce8bdd33a7
---

diff --git a/resources/src/startup/mediawiki.js b/resources/src/startup/mediawiki.js
index b5ba6a66a6..65cf3169bb 100644
--- a/resources/src/startup/mediawiki.js
+++ b/resources/src/startup/mediawiki.js
@@ -1102,6 +1102,12 @@
 			 * @param {Function} [callback] Callback to run after request resolution
 			 */
 			function addScript( src, callback ) {
+				// Use a <script> element rather than XHR. Using XHR changes the request
+				// headers (potentially missing a cache hit), and reduces caching in general
+				// since browsers cache XHR much less (if at all). And XHR means we retrieve
+				// text, so we'd need to eval, which then messes up line numbers.
+				// The drawback is that <script> does not offer progress events, feedback is
+				// only given after downloading, parsing, and execution have completed.
 				var script = document.createElement( 'script' );
 				script.src = src;
 				script.onload = script.onerror = function () {