From: Brion Vibber <brion@users.mediawiki.org>
Date: Sun, 12 Jun 2005 13:52:38 +0000 (+0000)
Subject: * (bug 650) Use a shorter cl_sortkey field to avoid breaking on MySQL 4.1
X-Git-Tag: 1.5.0beta1~197
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%20%22id_auteur=%24id%22%29%20.%20%22?a=commitdiff_plain;h=2aa6775224f830fff40bf3a55d6e0a303ce7f8e3;p=lhc%2Fweb%2Fwiklou.git

* (bug 650) Use a shorter cl_sortkey field to avoid breaking on MySQL 4.1
  when the default charset is set to utf8
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 21d9808853..9f9fc2abb8 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -280,6 +280,8 @@ Various bugfixes, small features, and a few experimental things:
 * (bug 650) Prominently link MySQL 4.1 help page in installer if a possible
   version conflict is detected
 * (bug 2394) Undo incompatible breakage to {{msg:}} compatiblity includes
+* (bug 650) Use a shorter cl_sortkey field to avoid breaking on MySQL 4.1
+  when the default charset is set to utf8
 
 
 === Caveats ===
diff --git a/maintenance/tables.sql b/maintenance/tables.sql
index 720dc5e11d..c03a3b880d 100644
--- a/maintenance/tables.sql
+++ b/maintenance/tables.sql
@@ -395,7 +395,12 @@ CREATE TABLE /*$wgDBprefix*/categorylinks (
   -- to determine sort order. Sorting is by binary order, which
   -- isn't always ideal, but collations seem to be an exciting
   -- and dangerous new world in MySQL...
-  cl_sortkey varchar(255) binary NOT NULL default '',
+  --
+  -- For MySQL 4.1+ with charset set to utf8, the sort key *index*
+  -- needs cut to be smaller than 1024 bytes (at 3 bytes per char).
+  -- To sort properly on the shorter key, this field needs to be
+  -- the same shortness.
+  cl_sortkey varchar(86) binary NOT NULL default '',
   
   -- This isn't really used at present. Provided for an optional
   -- sorting method by approximate addition time.
@@ -403,9 +408,8 @@ CREATE TABLE /*$wgDBprefix*/categorylinks (
   
   UNIQUE KEY cl_from(cl_from,cl_to),
   
-  -- This key is trouble. It's incomplete, AND it's too big
-  -- when collation is set to UTF-8. Bleeeacch!
-  KEY cl_sortkey(cl_to,cl_sortkey(128)),
+  -- We always sort within a given category...
+  KEY cl_sortkey(cl_to,cl_sortkey),
   
   -- Not really used?
   KEY cl_timestamp(cl_to,cl_timestamp)