From: Timo Tijhof <krinklemail@gmail.com>
Date: Thu, 13 Jun 2019 18:33:46 +0000 (+0100)
Subject: resourceloader: Remove redundant 'group' setting for StartupModule
X-Git-Tag: 1.34.0-rc.0~1348^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22articles_versions%22%2C%22id_article=%24id_article%22%29%20.%20%22?a=commitdiff_plain;h=95985d0e4951622ebeb0ed18f29b832280981110;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Remove redundant 'group' setting for StartupModule

This feaure exists for controlling cache fragmentation of modules
that are queued for loading. However, the startup module is never
"queued" for loading.

It's loading is hardwired into ResourceLoaderClientHtml and doesn't
use any batching and couldn't logically, given that by design it
has to be the first thing that loads and cannot be combined with
other code (because we need to be able to return early and control
what else gets loaded from there).

[0] https://www.mediawiki.org/wiki/ResourceLoader/Architecture#Balance

Change-Id: If8900c538ce623f6a9a68a3bbef0927b4b6ae346
---

diff --git a/includes/resourceloader/ResourceLoaderStartUpModule.php b/includes/resourceloader/ResourceLoaderStartUpModule.php
index efed418106..26e64d18c1 100644
--- a/includes/resourceloader/ResourceLoaderStartUpModule.php
+++ b/includes/resourceloader/ResourceLoaderStartUpModule.php
@@ -425,11 +425,4 @@ class ResourceLoaderStartUpModule extends ResourceLoaderModule {
 		// and hash it to determine the version (as used by E-Tag HTTP response header).
 		return true;
 	}
-
-	/**
-	 * @return string
-	 */
-	public function getGroup() {
-		return 'startup';
-	}
 }