Revert r57053 for now "bug 20860 [[Special:Allmessages]] to have direct (edit) link"
authorBrion Vibber <brion@users.mediawiki.org>
Wed, 30 Sep 2009 17:50:58 +0000 (17:50 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Wed, 30 Sep 2009 17:50:58 +0000 (17:50 +0000)
While a direct link is nice, the current implementation looks pretty bad the way the lines break in the giant table

RELEASE-NOTES
includes/specials/SpecialAllmessages.php

index 56057d5..0d46156 100644 (file)
@@ -538,7 +538,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   now links to the file rather than the file description page
 * Password fields built with HTMLForm now still have the type="password" attribute
   if $wgHtml5=false.
-* (bug 20860) Entries on Special:Allmessages now have direct "edit" link
 * (bug 20836) Preload now works for MediaWiki namespace
 
 == API changes in 1.16 ==
index 7fc9192..b88b6a6 100644 (file)
@@ -299,8 +299,7 @@ class AllmessagesTablePager extends TablePager {
 
                                $title = Title::makeTitle( NS_MEDIAWIKI, $value . $this->suffix );
                                $talk  = Title::makeTitle( NS_MEDIAWIKI_TALK, $value . $this->suffix );
-                               $edit  = $this->mSkin->link( $title, wfMsg( 'edit' ), array(), 'action=edit' );
-                               
+
                                if( $this->mCurrentRow->am_customised ){
                                        $title = $this->mSkin->linkKnown( $title, $wgLang->lcfirst( $value ) );
                                } else {
@@ -323,7 +322,7 @@ class AllmessagesTablePager extends TablePager {
                                                array( 'broken' )
                                        );
                                }
-                               return $title . ' (' . $wgLang->pipeList( array( $edit, $talk ) ) . ')';
+                               return $title . ' (' . $talk . ')';
 
                        case 'am_default' :
                                return Sanitizer::escapeHtmlAllowEntities( $value, ENT_QUOTES );