Small-scale data loss logged on Wikimedia along these lines: invalid URL written...

diff --git a/includes/ExternalStoreDB.php b/includes/ExternalStoreDB.php
index 9aa3af8..c37e706 100644 (file)
--- a/includes/ExternalStoreDB.php
+++ b/includes/ExternalStoreDB.php
@@ -136,6 +136,9 @@ class ExternalStoreDB {
                        array( 'blob_id' => $id, 'blob_text' => $data ), 
                        __METHOD__ );
                $id = $dbw->insertId();
+               if ( !$id ) {
+                       throw new MWException( __METHOD__.': no insert ID' );
+               }
                if ( $dbw->getFlag( DBO_TRX ) ) {
                        $dbw->immediateCommit();
                }