Revert, Follow-up: -1 recent contributors
authorEddie Greiner-Petter <git@eddie-sh.de>
Sat, 22 Apr 2017 19:23:11 +0000 (21:23 +0200)
committerKrinkle <krinklemail@gmail.com>
Thu, 27 Apr 2017 01:51:21 +0000 (01:51 +0000)
commitb140b73b54785966138c6296057c02046f72786f
treea8eac3d3edba184837d17e3881303c9d0310d170
parentfbcb7cc6c26fed8ff133e1f8582bd08080101544
Revert, Follow-up: -1 recent contributors

This reverts commit b67f40e5b01af569794eba26da79497329590d36.

There was an issue that the web installer, when inserting initial
values into the db table site_stats, would not insert any value for
ss_active_users. That lead to some places, most notably
Special:CreateAccount, to show off -1 recent contributors.

The commit to revert solved this by setting a default value of 1 for
the ss_active_users field in the database schema. However, while the
default schema has been changed, there hasn't been any schema update
procedure implemented. Also, the default of 1 is inconsistent with
other defaults in that table.

Revert that schema change completely. Instead, make the web installer
insert 0 to the field ss_active_users (just like it does with all other
fields in that table).

Bug: T56888
Change-Id: I4298754c2238f6e5447a5df77a4ada722ba302b2
includes/installer/Installer.php
maintenance/mssql/tables.sql
maintenance/oracle/tables.sql
maintenance/postgres/tables.sql
maintenance/tables.sql
tests/phpunit/includes/db/DatabaseSqliteTest.php