From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Mon, 6 Dec 2010 16:17:43 +0000 (+0000)
Subject: * (bug 26253) Removed $wgPostCommitUpdateList
X-Git-Tag: 1.31.0-rc.0~33517
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22articles%22%2C%22id_article=%24id_article%22%29%20.%20%22?a=commitdiff_plain;h=cb6f556784dad73d939951d3d1fa45cbe129e8be;p=lhc%2Fweb%2Fwiklou.git

* (bug 26253) Removed $wgPostCommitUpdateList

As I said on the bug, this variable is not used since ages
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 2fa6d15608..2a8413543b 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -96,6 +96,7 @@ LocalSettings.php. The specific bugs are listed below in the general notes.
   of LocalSettings.php, in LocalSettings.php itself. Instead, this is done 
   automatically if $wgInvalidateCacheOnLocalSettingsChange is true (which is 
   the default). 
+* (bug 26253) $wgPostCommitUpdateList has been removed
 
 === New features in 1.17 ===
 * (bug 10183) Users can now add personal styles and scripts to all skins via
diff --git a/docs/database.txt b/docs/database.txt
index 555347dccb..b9fa6ff711 100644
--- a/docs/database.txt
+++ b/docs/database.txt
@@ -146,9 +146,7 @@ to avoid long-lasting locks. By default, MediaWiki opens a transaction
 at the first query, and commits it before the output is sent. Locks will
 be held from the time when the query is done until the commit. So you
 can reduce lock time by doing as much processing as possible before you
-do your write queries. Update operations which do not require database
-access can be delayed until after the commit by adding an object to
-$wgPostCommitUpdateList.
+do your write queries.
 
 Often this approach is not good enough, and it becomes necessary to
 enclose small groups of queries in their own transaction. Use the
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index b7a95a5ce2..1d1a609507 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2862,15 +2862,11 @@ function wfMakeUrlIndex( $url ) {
  * TODO: This could be in Wiki.php if that class made any sense at all
  */
 function wfDoUpdates() {
-	global $wgPostCommitUpdateList, $wgDeferredUpdateList;
+	global $wgDeferredUpdateList;
 	foreach ( $wgDeferredUpdateList as $update ) {
 		$update->doUpdate();
 	}
-	foreach ( $wgPostCommitUpdateList as $update ) {
-		$update->doUpdate();
-	}
 	$wgDeferredUpdateList = array();
-	$wgPostCommitUpdateList = array();
 }
 
 /**
diff --git a/includes/Setup.php b/includes/Setup.php
index fbaac94b42..7c9fa49031 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -379,7 +379,6 @@ wfProfileOut( $fname.'-User' );
 wfProfileIn( $fname.'-misc2' );
 
 $wgDeferredUpdateList = array();
-$wgPostCommitUpdateList = array();
 
 if ( $wgAjaxUploadDestCheck ) $wgAjaxExportList[] = 'SpecialUpload::ajaxGetExistsWarning';
 
diff --git a/index.php b/index.php
index dcea36b5b7..b05ec513ce 100644
--- a/index.php
+++ b/index.php
@@ -115,8 +115,5 @@ $mediaWiki->setVal( 'UsePathInfo', $wgUsePathInfo );
 $mediaWiki->performRequestForTitle( $wgTitle, $wgArticle, $wgOut, $wgUser, $wgRequest );
 $mediaWiki->finalCleanup( $wgDeferredUpdateList, $wgOut );
 
-# Not sure when $wgPostCommitUpdateList gets set, so I keep this separate from finalCleanup
-$mediaWiki->doUpdates( $wgPostCommitUpdateList );
-
 $mediaWiki->restInPeace();