From: Brian Wolff <bawolff+wn@gmail.com>
Date: Tue, 26 Sep 2017 21:40:04 +0000 (+0000)
Subject: Do not include RC_EXTERNAL in number active users on Special:Statistics
X-Git-Tag: 1.31.0-rc.0~1929^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22articles%22%2C%22id_article=%24id_article%22%29%20.%20%22?a=commitdiff_plain;h=73e7b9cfcc49b0d08c2648132f613fefcd977b49;p=lhc%2Fweb%2Fwiklou.git

Do not include RC_EXTERNAL in number active users on Special:Statistics

We already exclude external (mostly Wikidata) actions from counting on
Special:ActiveUsers as of 56524c05. Should be consistent.

Change-Id: Ib69a614a65246a0f4f47365751f9bef130f47475
---

diff --git a/includes/deferred/SiteStatsUpdate.php b/includes/deferred/SiteStatsUpdate.php
index 2f074ba2d3..44876a68ef 100644
--- a/includes/deferred/SiteStatsUpdate.php
+++ b/includes/deferred/SiteStatsUpdate.php
@@ -149,6 +149,7 @@ class SiteStatsUpdate implements DeferrableUpdate, MergeableUpdate {
 			'recentchanges',
 			'COUNT( DISTINCT rc_user_text )',
 			[
+				'rc_type != ' . $dbr->addQuotes( RC_EXTERNAL ), // Exclude external (Wikidata)
 				'rc_user != 0',
 				'rc_bot' => 0,
 				'rc_log_type != ' . $dbr->addQuotes( 'newusers' ) . ' OR rc_log_type IS NULL',