Specifically in registerFiltersFromDefinitions(), phan was unable to
tell that $groupDefinition['class'] was a string. I think it assumed it
was an integer because the earlier $groupDefinition['priority'] was an
integer.
Use phan's more advanced type documentation system to instruct it that
$className will be a string.
Change-Id: I09f41366b713d6159b57e798cfd1720f42ba30ef
"PhanTypeComparisonFromArray",
// approximate error count: 2
"PhanTypeComparisonToArray",
- // approximate error count: 2
- "PhanTypeExpectedObjectOrClassName",
// approximate error count: 7
"PhanTypeExpectedObjectPropAccess",
// approximate error count: 63
*
* There is light processing to simplify core maintenance.
* @param array $definition
+ * @phan-param array<int,array{class:string}> $definition
*/
protected function registerFiltersFromDefinitions( array $definition ) {
$autoFillPriority = -1;
$filterDefinition = $this->transformFilterDefinition( $filterDefinition );
}
- // @phan-suppress-next-line PhanNonClassMethodCall
$this->registerFilterGroup( new $className( $groupDefinition ) );
}
}