Partial revert of r41018 "Wrap $log->addEntry() in transaction"
authorAryeh Gregor <simetrical@users.mediawiki.org>
Mon, 16 Feb 2009 16:50:22 +0000 (16:50 +0000)
committerAryeh Gregor <simetrical@users.mediawiki.org>
Mon, 16 Feb 2009 16:50:22 +0000 (16:50 +0000)
commit86bbdc25f461ac3a41106c05c736fb3ac0718e69
treefbe43c7a45bc86c1838b701302caa869c9b568c7
parent4f44243692da2a413eead519c3bb82c4e70590a8
Partial revert of r41018 "Wrap $log->addEntry() in transaction"

In addition to wrapping the given function call in a transaction, the
commit also (without explanation or apparent purpose) moved a block of
code to a totally different place, which broke it entirely.
Specifically, it moved the update of the category table on article
delete to AFTER THE CATEGORYLINKS ROWS WERE ALREADY DELETED, which meant
that it found the article was in no categories, and article deletions
silently failed to decrement the category count (bug 17155).

Could you PLEASE not commit all sorts of stuff under the guise of
one-line commit messages that don't actually relate to what you did.
Thank you.
includes/Article.php