From 48cc8109c80f8e1fd1fc4af565c119911cdb198d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Tue, 26 Nov 2013 23:13:51 +0100 Subject: [PATCH] Wrap changes lists in
This affects Watchlist, RecentChanges and RecentChangesLinked. A
is already used on all of these when the list isn't generated (somewhat inconsistently coded, though). Bug: 8844 Change-Id: I1ab2a54e22f318713c2211d63b29c184751a3589 --- includes/changes/ChangesList.php | 10 ++++------ includes/changes/EnhancedChangesList.php | 4 ++-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/includes/changes/ChangesList.php b/includes/changes/ChangesList.php index a9c3a677bc..470b150c6c 100644 --- a/includes/changes/ChangesList.php +++ b/includes/changes/ChangesList.php @@ -162,7 +162,7 @@ class ChangesList extends ContextSource { $this->rclistOpen = false; $this->getOutput()->addModuleStyles( 'mediawiki.special.changeslist' ); - return ''; + return '
'; } /** @@ -246,11 +246,9 @@ class ChangesList extends ContextSource { * @return String */ public function endRecentChangesList() { - if ( $this->rclistOpen ) { - return "\n"; - } else { - return ''; - } + $out = $this->rclistOpen ? "\n" : ''; + $out .= '
'; + return $out; } /** diff --git a/includes/changes/EnhancedChangesList.php b/includes/changes/EnhancedChangesList.php index 1727da02aa..1c3a0fbd96 100644 --- a/includes/changes/EnhancedChangesList.php +++ b/includes/changes/EnhancedChangesList.php @@ -43,7 +43,7 @@ class EnhancedChangesList extends ChangesList { 'mediawiki.icon', ) ); - return ''; + return '
'; } /** @@ -689,6 +689,6 @@ class EnhancedChangesList extends ChangesList { * @return string */ public function endRecentChangesList() { - return $this->recentChangesBlock() . parent::endRecentChangesList(); + return $this->recentChangesBlock() . '
'; } } -- 2.20.1