Merge "Replace call_user_func_array(), part 2"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sat, 9 Jun 2018 14:25:26 +0000 (14:25 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sat, 9 Jun 2018 14:25:26 +0000 (14:25 +0000)
1  2 
includes/MovePage.php

diff --combined includes/MovePage.php
@@@ -57,7 -57,7 +57,7 @@@ class MovePage 
                // Convert into a Status object
                if ( $errors ) {
                        foreach ( $errors as $error ) {
-                               call_user_func_array( [ $status, 'fatal' ], $error );
+                               $status->fatal( ...$error );
                        }
                }
  
                        new AtomicSectionUpdate(
                                $dbw,
                                __METHOD__,
 -                              function () use ( $params ) {
 +                              // Hold onto $user to avoid HHVM bug where it no longer
 +                              // becomes a reference (T118683)
 +                              function () use ( $params, &$user ) {
                                        Hooks::run( 'TitleMoveComplete', $params );
                                }
                        )