From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Thu, 15 May 2008 17:04:34 +0000 (+0000)
Subject: (bug 13693) Categories sometimes claim to have a negative number of members.  Just... 
X-Git-Tag: 1.31.0-rc.0~47613
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22messagerie%22%29%20.%20%22?a=commitdiff_plain;h=38ce75b48122f85546a3fa513fb7220903789415;p=lhc%2Fweb%2Fwiklou.git

(bug 13693) Categories sometimes claim to have a negative number of members.  Just recount them in this case; they *should* have relatively few members, so it should be fast.  Note that even a worst-case scenario (recount of enwiki Living people) takes only a few seconds on the cluster, and it seems incredibly unlikely that that would occur.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 16065f836d..2c05a8338b 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -274,6 +274,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 14063) Power search form missing <label> for redirects check
 * (bug 14111) Similar filename warning links now lead to correct page
 * (bug 14082) Fix for complex text input vs AJAX suggestions on some browsers
+* (bug 13693) Categories sometimes claim to have a negative number of members
 
 
 === API changes in 1.13 ===
diff --git a/includes/Category.php b/includes/Category.php
index 37127d5484..15e56b1f1a 100644
--- a/includes/Category.php
+++ b/includes/Category.php
@@ -237,6 +237,15 @@ class Category extends CategoryListBase {
 	 */
 	protected function initialize() {
 		parent::initialize();
+
+		# (bug 13683) If the count is negative, then 1) it's obviously wrong
+		# and should not be kept, and 2) we *probably* don't have to scan many
+		# rows to obtain the correct figure, so let's risk a one-time recount.
+		if( $this->mPages[0] < 0 || $this->mSubcats[0] < 0 ||
+		$this->mFiles[0] < 0 ) {
+			$this->refreshCounts();
+		}
+
 		if( count( $this->mNames ) != 1 || count( $this->mIDs ) != 1 ) {
 			return false;
 		}