From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Mon, 4 Sep 2017 16:04:28 +0000 (+0200)
Subject: SpecialUpload: Stop loading 'mediawiki.action.edit'
X-Git-Tag: 1.31.0-rc.0~2222^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22calendrier%22%2C%22type=semaine%22%29%20.%20%22?a=commitdiff_plain;h=dd3410c46e4150e74f91ae6f03df1851db1e3ff4;p=lhc%2Fweb%2Fwiklou.git

SpecialUpload: Stop loading 'mediawiki.action.edit'

The comment says it's for <charinsert> support, but that's not true
anymore, as the CharInsert extension itself takes care of loading its
script on Special:Upload (see CharInsert::onBeforePageDisplay()).

Back in the day, this module included a lot more stuff related to the
edit toolbar and such, so this might have been warranted, but there is
nothing useful for uploading left in it anymore.

It's very unintuitive that it would be loaded there; folks did not
realize that it is the case and recent changes to the module started
causing issues on Special:Upload.

Bug: T174935
Change-Id: I11e886801a27f796e5a5935ec9c93b1329cc5b87
---

diff --git a/includes/specials/SpecialUpload.php b/includes/specials/SpecialUpload.php
index 4cdc78f341..d0eb8e3742 100644
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -1256,7 +1256,6 @@ class UploadForm extends HTMLForm {
 		$out->addJsConfigVars( $scriptVars );
 
 		$out->addModules( [
-			'mediawiki.action.edit', // For <charinsert> support
 			'mediawiki.special.upload', // Extras for thumbnail and license preview.
 		] );
 	}