RecentChange: deprecate newFromCurRow and loadFromCurRow
authorRuud Koot <inbox@ruudkoot.nl>
Fri, 24 May 2013 14:49:50 +0000 (16:49 +0200)
committerRuud Koot <inbox@ruudkoot.nl>
Sat, 25 May 2013 09:02:32 +0000 (11:02 +0200)
This is ancient code related to the no-longer existing cur table,
which doesn't seem to be fully correct anymore and is only called
from the (deprecated) Oversight extension.

Change-Id: I0b40e3fb17ec670c5c85c8ee0dd2e8b74d72e548

includes/RecentChange.php

index b5d4a1c..386b393 100644 (file)
@@ -96,10 +96,12 @@ class RecentChange {
        }
 
        /**
+        * @deprecated in 1.22 (cur table no longer exists)
         * @param $row
         * @return RecentChange
         */
        public static function newFromCurRow( $row ) {
+               wfDeprecated( ___METHOD__ , '1.22' );
                $rc = new RecentChange;
                $rc->loadFromCurRow( $row );
                $rc->notificationtimestamp = false;
@@ -653,9 +655,11 @@ class RecentChange {
        /**
         * Makes a pseudo-RC entry from a cur row
         *
+        * @deprected in 1.22 (cur table no longer exists)
         * @param $row
         */
        public function loadFromCurRow( $row ) {
+               wfDeprecated( ___METHOD__ , '1.22' );
                $this->mAttribs = array(
                        'rc_timestamp' => wfTimestamp( TS_MW, $row->rev_timestamp ),
                        'rc_cur_time' => $row->rev_timestamp,