From 7706ef1e67933bc85f2202c175d3652e379cb491 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sat, 9 Mar 2019 05:06:36 +0000 Subject: [PATCH] resourceloader: Remove redundant var-freeing in addScript() This was copied from jQuery 1.x, where it existed to reduce memory usage in IE6-8. This was because it's JS engine was not able to break the circular closure reference (the function invocation has a reference to the script element, the script element has an event listener with closure access to the script element). This bug is no longer relevant. Change-Id: I6fd66c5fbf3afb3c9e09bba6322dc3fac2fad4a6 --- resources/src/startup/mediawiki.js | 1 - 1 file changed, 1 deletion(-) diff --git a/resources/src/startup/mediawiki.js b/resources/src/startup/mediawiki.js index a0c7c61983..5c574a2efa 100644 --- a/resources/src/startup/mediawiki.js +++ b/resources/src/startup/mediawiki.js @@ -1120,7 +1120,6 @@ if ( script.parentNode ) { script.parentNode.removeChild( script ); } - script = null; if ( callback ) { callback(); callback = null; -- 2.20.1