From 5161ee2a658c843d7c76ec6f680fb3939885f9c1 Mon Sep 17 00:00:00 2001 From: Prateek Saxena Date: Tue, 7 Aug 2018 10:44:55 +0530 Subject: [PATCH] LogEventsList: Stop showing deprecation warning when $input is empty Follows-up on I697e158887fcca1da88763a4c929a981d9211490 Bug: T201006 Change-Id: I140cde3f71e2bd8106f0c0ce7da1ec822a8da072 --- includes/logging/LogEventsList.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/includes/logging/LogEventsList.php b/includes/logging/LogEventsList.php index f032efc5c5..a5aa6879e9 100644 --- a/includes/logging/LogEventsList.php +++ b/includes/logging/LogEventsList.php @@ -130,10 +130,13 @@ class LogEventsList extends ContextSource { !empty( $extraInputsDescriptor ) ) { $formDescriptor[ 'extra' ] = $extraInputsDescriptor; - } elseif ( is_string( $extraInputsDescriptor ) ) { + } elseif ( + is_string( $extraInputsDescriptor ) && + $extraInputsDescriptor !== '' + ) { // We'll add this to the footer of the form later $extraInputsString = $extraInputsDescriptor; - wfDeprecated( 'Using $input in LogEventsListGetExtraInputs hook', '1.32' ); + wfDeprecated( '$input in LogEventsListGetExtraInputs hook', '1.32' ); } // Title pattern, if allowed -- 2.20.1