From 14eb73f6ed7b2b2b285ba8cdb59d3cb3954b194d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Tue, 30 Jan 2018 10:26:15 +0100 Subject: [PATCH] jquery.textSelection: Remove outdated FIXME comments These are from 2010 or earlier; they blame to 32377424b94 / rSVN72349, which is a huge SVN branch merge and I'm not going to dig past that. To be honest I don't really understand them (perhaps some context has been lost over the years), but their main point is "we may not need these functions", to which I say we definitely need them because they've been a public API for over 7 years now. Change-Id: I43a5453003e8d64d00323eb973629a96b6b386ab --- resources/src/jquery/jquery.textSelection.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/resources/src/jquery/jquery.textSelection.js b/resources/src/jquery/jquery.textSelection.js index 522e95b871..e7ae467853 100644 --- a/resources/src/jquery/jquery.textSelection.js +++ b/resources/src/jquery/jquery.textSelection.js @@ -554,7 +554,6 @@ // Return [start, end] instead of just start startAndEnd: false }, options ); - // FIXME: We may not need character position-based functions if we insert markers in the right places break; case 'setSelection': options = $.extend( { @@ -567,7 +566,6 @@ if ( options.end === undefined ) { options.end = options.start; } - // FIXME: We may not need character position-based functions if we insert markers in the right places break; case 'scrollToCaretPosition': options = $.extend( { -- 2.20.1