From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Thu, 20 Dec 2018 16:51:42 +0000 (+0100)
Subject: Add missing, dynamically declared properties in ContribsPager
X-Git-Tag: 1.34.0-rc.0~3202
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%20%22id_auteur=%24id%22%29%20.%20%22?a=commitdiff_plain;h=a67a4b10871a11fcbf20d2ea671d2e80202942a5;p=lhc%2Fweb%2Fwiklou.git

Add missing, dynamically declared properties in ContribsPager

These are all set in the constructor, and don't need a default because
of this.

I'm also adding documentation for the class properties in this class as
good as I can (type, possible values, meaning, and behavior).

Change-Id: Ic2367ca7e8d8b2b7ae4f80ad04081a0db2821de5
---

diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php
index 2bfc923e3a..c87caecd96 100644
--- a/includes/specials/pagers/ContribsPager.php
+++ b/includes/specials/pagers/ContribsPager.php
@@ -31,9 +31,64 @@ use Wikimedia\Rdbms\IDatabase;
 class ContribsPager extends RangeChronologicalPager {
 
 	public $mDefaultDirection = IndexPager::DIR_DESCENDING;
+
+	/**
+	 * @var string[] Local cache for escaped messages
+	 */
 	public $messages;
+
+	/**
+	 * @var string User name, or a string describing an IP address range
+	 */
 	public $target;
+
+	/**
+	 * @var string Set to "newbie" to list contributions from the most recent 1% registered users.
+	 *  $this->target is ignored then. Defaults to "users".
+	 */
+	private $contribs;
+
+	/**
+	 * @var string|int A single namespace number, or an empty string for all namespaces
+	 */
 	public $namespace = '';
+
+	/**
+	 * @var string|false Name of tag to filter, or false to ignore tags
+	 */
+	private $tagFilter;
+
+	/**
+	 * @var bool Set to true to invert the namespace selection
+	 */
+	private $nsInvert;
+
+	/**
+	 * @var bool Set to true to show both the subject and talk namespace, no matter which got
+	 *  selected
+	 */
+	private $associated;
+
+	/**
+	 * @var bool Set to true to show only deleted revisions
+	 */
+	private $deletedOnly;
+
+	/**
+	 * @var bool Set to true to show only latest (a.k.a. current) revisions
+	 */
+	private $topOnly;
+
+	/**
+	 * @var bool Set to true to show only new pages
+	 */
+	private $newOnly;
+
+	/**
+	 * @var bool Set to true to hide edits marked as minor by the user
+	 */
+	private $hideMinor;
+
 	public $mDb;
 	public $preventClickjacking = false;