From: Derick Alangi <alangiderick@gmail.com>
Date: Wed, 20 Mar 2019 17:36:03 +0000 (+0100)
Subject: db: Remove property assignment overriden by constructor
X-Git-Tag: 1.34.0-rc.0~2457^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22auteur_infos%22%2C%20%22id_auteur=%24id%22%29%20.%20%22?a=commitdiff_plain;h=7efdf701ba4a8ef13ef36d1f08811ab3069b1539;p=lhc%2Fweb%2Fwiklou.git

db: Remove property assignment overriden by constructor

As these class properties are overriden by the class constructor,
we can safely remove them. In addition, remove a useless "/" in a
PHPDoc.

Change-Id: I9cecfc8a0e5b58c931ee32c7465c064a9add1a77
---

diff --git a/includes/db/CloneDatabase.php b/includes/db/CloneDatabase.php
index d4277245c1..cdf0f797df 100644
--- a/includes/db/CloneDatabase.php
+++ b/includes/db/CloneDatabase.php
@@ -25,16 +25,16 @@ use Wikimedia\Rdbms\IMaintainableDatabase;
 
 class CloneDatabase {
 	/** @var string Table prefix for cloning */
-	private $newTablePrefix = '';
+	private $newTablePrefix;
 
 	/** @var string Current table prefix */
-	private $oldTablePrefix = '';
+	private $oldTablePrefix;
 
 	/** @var array List of tables to be cloned */
-	private $tablesToClone = [];
+	private $tablesToClone;
 
 	/** @var bool Should we DROP tables containing the new names? */
-	private $dropCurrentTables = true;
+	private $dropCurrentTables;
 
 	/** @var bool Whether to use temporary tables or not */
 	private $useTemporaryTables = true;
@@ -128,7 +128,7 @@ class CloneDatabase {
 	}
 
 	/**
-	 * Change the table prefix on all open DB connections/
+	 * Change the table prefix on all open DB connections
 	 *
 	 * @param string $prefix
 	 * @return void