Merge "block: Avoid use of empty() which doesn't warn on var non-existence"

diff --combined includes/block/BlockRestriction.php
index ca36cda,c5ab16f..b92cda8
--- 1/includes/block/BlockRestriction.php
--- 2/includes/block/BlockRestriction.php
+++ b/includes/block/BlockRestriction.php
@@@ -73,7 -73,7 +73,7 @@@ class BlockRestriction 
         * @return bool
         */
        public static function insert( array $restrictions ) {
-               if ( empty( $restrictions ) ) {
+               if ( !$restrictions ) {
                        return false;
                }
  
@@@ -85,20 -85,18 +85,20 @@@
                        $rows[] = $restriction->toRow();
                }
  
-               if ( empty( $rows ) ) {
+               if ( !$rows ) {
                        return false;
                }
  
                $dbw = wfGetDB( DB_MASTER );
  
 -              return $dbw->insert(
 +              $dbw->insert(
                        'ipblocks_restrictions',
                        $rows,
                        __METHOD__,
                        [ 'IGNORE' ]
                );
 +
 +              return true;
        }
  
        /**