jenkins-bot [Wed, 18 Apr 2018 23:32:34 +0000 (23:32 +0000)]
Merge "Remove $wgSiteSupportPage"
mainframe98 [Wed, 18 Apr 2018 16:05:52 +0000 (18:05 +0200)]
Remove $wgSiteSupportPage
This configuration global is not used anywhere in MediaWiki,
and no extensions or skins use this.
The documentation on mediawiki.org states that the functionality
has been replaced by MediaWiki:Sidebar, and $wgNavigationLinks,
which was removed over a decade ago.
Bug: T192467
Change-Id: Iea1f8a688feb1c7aa8d0005f207a13956bddfd4e
Reedy [Wed, 18 Apr 2018 21:23:27 +0000 (22:23 +0100)]
Fix supported mysql version in RELEASE-NOTES
Change-Id: I7e8dd036a7a8403f71208fd4c1302d4e241c6378
Translation updater bot [Wed, 18 Apr 2018 19:55:41 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I61420aa859aeb1ab6ee2f62b5260e0b0dac0685f
jenkins-bot [Wed, 18 Apr 2018 19:52:44 +0000 (19:52 +0000)]
Merge "ImportStreamSource: Replace magic numbers with constants"
jenkins-bot [Wed, 18 Apr 2018 19:33:04 +0000 (19:33 +0000)]
Merge "Reduce some nesting in CryptRand.php"
jenkins-bot [Wed, 18 Apr 2018 18:56:32 +0000 (18:56 +0000)]
Merge "Replace recently introduced mediawiki/at-ease calls"
jenkins-bot [Wed, 18 Apr 2018 18:47:13 +0000 (18:47 +0000)]
Merge "Test ApiMove"
Max Semenik [Wed, 18 Apr 2018 17:43:51 +0000 (10:43 -0700)]
Sync PG version in INSTALL
Change-Id: I31f65bba28e8b600aa275bf287cd73dec98d96dc
jenkins-bot [Wed, 18 Apr 2018 16:22:16 +0000 (16:22 +0000)]
Merge "Setup: Move mbstring.func_overload from WebStart to Setup"
jenkins-bot [Wed, 18 Apr 2018 16:02:08 +0000 (16:02 +0000)]
Merge "Swap mediawiki/at-ease for wikimedia/at-ease"
jenkins-bot [Wed, 18 Apr 2018 15:21:25 +0000 (15:21 +0000)]
Merge "Fix PHPDoc type hints in CacheTime, ParserOptions, and related"
Thiemo Kreuz [Wed, 18 Apr 2018 12:31:13 +0000 (14:31 +0200)]
Fix PHPDoc type hints in CacheTime, ParserOptions, and related
I'm intentionally not touching any code in this patch, only
documentation.
Change-Id: I6975194c218760031789d5335dfbb330017dc6fc
Reedy [Wed, 18 Apr 2018 14:10:42 +0000 (14:10 +0000)]
Replace recently introduced mediawiki/at-ease calls
Change-Id: I1f6b7ed199faf4c8f3a3932731507c18413ad6e6
Reedy [Wed, 18 Apr 2018 12:35:14 +0000 (13:35 +0100)]
Swap mediawiki/at-ease for wikimedia/at-ease
Bump wikimedia/php-session-serializer to v1.0.6
Change-Id: I9ed96a29d6db39206377b45e3d46cb2082587f75
Depends-On: I963a61135d66b8baa4638979fd21077d925276b9
Reedy [Wed, 18 Apr 2018 11:59:13 +0000 (11:59 +0000)]
Reduce some nesting in CryptRand.php
Change-Id: Ic0b7307d66f877a5b1df974f34846857084dc23a
jenkins-bot [Wed, 18 Apr 2018 11:43:22 +0000 (11:43 +0000)]
Merge "mw.widgets.visibleLengthLimit: Apply number conversion to the limit"
jenkins-bot [Wed, 18 Apr 2018 10:53:24 +0000 (10:53 +0000)]
Merge "Fix bad archive file names in ImportableUploadRevisionImporter"
jenkins-bot [Wed, 18 Apr 2018 10:22:11 +0000 (10:22 +0000)]
Merge "Special:ProtectedPages: Use MultiSelectField instead of checks"
Timo Tijhof [Wed, 18 Apr 2018 02:14:30 +0000 (03:14 +0100)]
installer: Clean up ext-dependency jQuery code
Follows-up
c8833d8e8ecc.
* Select the input elements by class to avoid accidentally trigging
on unrelated elements elsewhere on the page in the future, given
the generic selector.
* Use on('change') instead of deprecated change() alias.
* Set properties directly instead of via prop() indirection.
* Get attribute directly instead of via data() indirection.
Change-Id: I5158aa26b5fd7327d6795f0a31bbffbe99043fbf
Timo Tijhof [Wed, 18 Apr 2018 01:59:36 +0000 (02:59 +0100)]
installer: Open skin screenshot in new window
By default the plain links hijack the current window, thus
causing the user to lose their current changes to the installer
form. It may also cause confusion as to how to get back.
Absence a modal way to view the image, at least it should default
to opening the image in a new tab.
Change-Id: I4a25f1f51e04a33f1f359f12af25b8e1db5fbd20
jenkins-bot [Wed, 18 Apr 2018 01:37:35 +0000 (01:37 +0000)]
Merge "build: Drop PHP 5 from Travis matrix"
jenkins-bot [Wed, 18 Apr 2018 01:24:01 +0000 (01:24 +0000)]
Merge "Update CREDITS and .mailmap"
Timo Tijhof [Wed, 18 Apr 2018 01:05:33 +0000 (02:05 +0100)]
Update CREDITS and .mailmap
Before this change, running the script would add the following:
* Cicalese: Duplicate. Fixed by adding another address to mailmap.
Follows-up
3b55b0b3b8.
* gopavasanth: Added.
* Guycn2: Added.
* Zoranzoki21: Duplicate. Fixed by normalising their name via mailmap.
Also, remove the following added by
19ccff96086b70b:
* GeoffreyT2000: Duplicate. Already normalised by mailmap.
Change-Id: I5b11444a74dad090e484c2e256d32de5f6792943
jenkins-bot [Wed, 18 Apr 2018 01:02:18 +0000 (01:02 +0000)]
Merge "Deprecate $wgUseAjax, act as always-true"
Timo Tijhof [Wed, 18 Apr 2018 00:58:50 +0000 (01:58 +0100)]
build: Drop PHP 5 from Travis matrix
We already cover this in our own Jenkins CI, and apparently
the PHP 5.5+mysql build recently started failing with a
segmentation fault for unknown reasons.
Change-Id: Ie041d5378155bb9ddcbf413f546a3a04efcb4b4f
jenkins-bot [Wed, 18 Apr 2018 00:53:12 +0000 (00:53 +0000)]
Merge "Drop deprecated EnableAPI and EnableWriteAPI settings"
James D. Forrester [Thu, 22 Mar 2018 21:27:45 +0000 (14:27 -0700)]
Deprecate $wgUseAjax, act as always-true
Change-Id: Ia224c7ea1f902714e2c11bdebb9dadcd1ddfe43f
jenkins-bot [Wed, 18 Apr 2018 00:45:42 +0000 (00:45 +0000)]
Merge "Update OOUI to v0.26.4"
James D. Forrester [Mon, 20 Nov 2017 23:50:22 +0000 (15:50 -0800)]
Drop deprecated EnableAPI and EnableWriteAPI settings
The siteinfo API response's 'writeapi' value is now hard-set to true,
as are the ResourceLoader variables wgEnableAPI and wgEnableWriteAPI,
to be deprecated later.
Bug: T115414
Change-Id: I54ff9428b247ba203d67aba079149393f323d5a9
jenkins-bot [Wed, 18 Apr 2018 00:25:42 +0000 (00:25 +0000)]
Merge "CREDITS bump"
Chad Horohoe [Tue, 3 Apr 2018 20:21:44 +0000 (13:21 -0700)]
CREDITS bump
Bug: T191090
Change-Id: I8f751e09b1f1429d1c3d98782ff75bb09adc566c
James D. Forrester [Wed, 18 Apr 2018 00:05:33 +0000 (17:05 -0700)]
Update OOUI to v0.26.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.26.4
Depends-On: I41080edad6079b0ab792f65965f0c49753070d35
Change-Id: I41080edad6079b0ab792f65965f0c49753070d36
jenkins-bot [Tue, 17 Apr 2018 23:12:44 +0000 (23:12 +0000)]
Merge "Migrate PurgeJobUtils callback to AutoCommitUpdate"
Timo Tijhof [Tue, 17 Apr 2018 22:17:39 +0000 (23:17 +0100)]
WebStart: Remove deprecated $wgRequestTime
This variable is not read anywhere in Wikimedia Git.
Follows-up
06ba5ca383e2.
Bug: T189966
Change-Id: Ib86ebc44b12fee3a986838c5a302540b97066e5a
Timo Tijhof [Tue, 17 Apr 2018 22:07:48 +0000 (23:07 +0100)]
Setup: Move mbstring.func_overload from WebStart to Setup
Follows-up
26c2d03c17,
41d1fa1c3a and r11547 (
c7f363f886).
Also add references to the relevant tasks about why the check
exists.
Bug: T189966
Change-Id: Ic1f0c79a1b5638bb30351a0cab55699931d1fded
jenkins-bot [Tue, 17 Apr 2018 21:54:32 +0000 (21:54 +0000)]
Merge "WebStart: Remove redundant unset() for $IP"
jenkins-bot [Tue, 17 Apr 2018 21:48:29 +0000 (21:48 +0000)]
Merge "RELEASE-NOTES: Add note for StartProfiler deprecation"
Timo Tijhof [Tue, 17 Apr 2018 21:33:41 +0000 (22:33 +0100)]
WebStart: Remove redundant unset() for $IP
This seems redundant given it is unconditionally being set
two statements later. Probably a left-over from r36353 (
c6b902f180),
which did an unset() because there was another variable called
$preIP, and the original would no longer be needed.
However, we currently only use one variable ($IP) and there's no
need to unset() it before setting.
Bug: T189966
Change-Id: I17d516709beabeb80bd72b37f70ac9b666a501d4
jenkins-bot [Tue, 17 Apr 2018 21:36:45 +0000 (21:36 +0000)]
Merge "Special:Statistics: Be consistent in having ' (list of members)' after each row"
jenkins-bot [Tue, 17 Apr 2018 21:33:25 +0000 (21:33 +0000)]
Merge "resourceloader: Disable a flaky MessageBlobStoreTest case"
Timo Tijhof [Tue, 17 Apr 2018 21:29:36 +0000 (22:29 +0100)]
RELEASE-NOTES: Add note for StartProfiler deprecation
Follows-up
5209adff6c which just missed the 1.31 boat.
Change-Id: Ia7501e07ccd6498c24ff02f407be1c39414ab97e
jenkins-bot [Tue, 17 Apr 2018 21:28:04 +0000 (21:28 +0000)]
Merge "Prepare for REL1_31 cut, labelling master as 1.32-alpha"
James D. Forrester [Mon, 26 Feb 2018 22:06:01 +0000 (14:06 -0800)]
Special:Statistics: Be consistent in having ' (list of members)' after each row
Change-Id: I7736c5fb6032f1b7e8a60b49d422435a8c8e4962
Timo Tijhof [Tue, 17 Apr 2018 21:19:36 +0000 (22:19 +0100)]
resourceloader: Disable a flaky MessageBlobStoreTest case
Sometimes fails on the mediawiki-phpunit-php70-jessie job.
Bug: T176097
Change-Id: Id8c142954d597e1efaa326795f419d48b7af8bdf
James D. Forrester [Tue, 17 Apr 2018 18:24:01 +0000 (11:24 -0700)]
Prepare for REL1_31 cut, labelling master as 1.32-alpha
Change-Id: Id0aaad5a06cb90c4b2b81fa233a0a622aaf91a1e
jenkins-bot [Tue, 17 Apr 2018 20:22:23 +0000 (20:22 +0000)]
Merge "Setup: Deprecate StartProfiler, move default to DefaultSettings"
Translation updater bot [Tue, 17 Apr 2018 20:01:19 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ief0643ed5d9b0480f61cd380103e425e986eaa23
jenkins-bot [Tue, 17 Apr 2018 19:30:47 +0000 (19:30 +0000)]
Merge "Do not start explicit transaction rounds for RecentChangesUpdateJob"
jenkins-bot [Tue, 17 Apr 2018 18:35:10 +0000 (18:35 +0000)]
Merge "rdbms: remove "m" prefix from LoadBalancer comments"
jenkins-bot [Tue, 17 Apr 2018 18:34:19 +0000 (18:34 +0000)]
Merge "mediawiki.loader: Clean up unit tests"
jenkins-bot [Tue, 17 Apr 2018 15:55:08 +0000 (15:55 +0000)]
Merge "mw.widgets.UsersMultiselectWidget: Compat with mw.special.preferences.confirmClose"
jenkins-bot [Tue, 17 Apr 2018 15:50:38 +0000 (15:50 +0000)]
Merge "mw.special.preferences.confirmClose: Handle textareas"
jenkins-bot [Tue, 17 Apr 2018 15:44:56 +0000 (15:44 +0000)]
Merge "RCFilters: Prevent trigger element movement"
jenkins-bot [Tue, 17 Apr 2018 15:18:39 +0000 (15:18 +0000)]
Merge "Handle extension dependencies in the installer"
jenkins-bot [Tue, 17 Apr 2018 14:55:19 +0000 (14:55 +0000)]
Merge "resourceloader: Remove getHashMtime() and getDefinitionMtime() methods"
Bartosz Dziewoński [Tue, 17 Apr 2018 13:05:05 +0000 (15:05 +0200)]
mw.widgets.UsersMultiselectWidget: Compat with mw.special.preferences.confirmClose
Replace `<input type="hidden">` with a `<textarea>` hidden using
`display: none`, because the former does not have separate 'value'
and 'defaultValue' properties, and the Special:Preferences script to
enable/disable the "Save" button depends on them to work correctly.
We use a similar approach in OOUI (RadioSelectInputWidget).
Also correct a code comment (we need to trigger a 'change' event for
any kind of input, not just `<input type="hidden">`).
Bug: T192147
Change-Id: I2351bc752f9cf25a607f4b197c132062d52ecb1e
Bartosz Dziewoński [Tue, 17 Apr 2018 13:11:59 +0000 (15:11 +0200)]
mw.special.preferences.confirmClose: Handle textareas
Bug: T192147
Change-Id: Ie02c5d8cab7db091054f7d66633c6ec34354ee19
Aaron Schulz [Mon, 16 Apr 2018 20:38:01 +0000 (13:38 -0700)]
Do not start explicit transaction rounds for RecentChangesUpdateJob
The replaces the hacky use of onTransactionIdle(), which no longer runs
immediately in explicit transaction rounds since
d4c31cf841.
Also clarified TransactionRoundDefiningUpdate comment about rounds.
Change-Id: Ie17eacdcaea4e47019cc94e1c7beed9d7fec5cf2
Aaron Schulz [Tue, 17 Apr 2018 04:20:58 +0000 (21:20 -0700)]
rdbms: remove "m" prefix from LoadBalancer comments
Change-Id: Ie239157eb6ee8b7991c45ef5c5c06a1caaba52c9
Volker E [Tue, 17 Apr 2018 04:20:39 +0000 (21:20 -0700)]
RCFilters: Prevent trigger element movement
Change-Id: Ic04229ade53a42a47ccbd909640b848cf9979eb1
Fomafix [Fri, 16 Feb 2018 10:36:59 +0000 (11:36 +0100)]
Use module.exports for mediawiki.libs.jpegmeta
Deprecate mw.libs.jpegmeta. Use
mw.loader.require( 'mediawiki.libs.jpegmeta' )
instead.
Change-Id: I8a7fb7377248a2ce1cf9c6d3c888ca9835cadaad
Timo Tijhof [Tue, 17 Apr 2018 00:42:00 +0000 (01:42 +0100)]
resourceloader: Remove getHashMtime() and getDefinitionMtime() methods
Deprecated since 1.26, no callers or implementors in Wikimedia Git.
Change-Id: Ie44b4be47db7a4799fe39d66294c41238c62f51f
Timo Tijhof [Tue, 17 Apr 2018 00:40:48 +0000 (01:40 +0100)]
resourceloader: Add @covers for covered deprecated methods
These are deprecated for extensions to implement, but still
supported and already triggered by the test cases. Previously
not mentioned because they were ignored by PHPUnit, but not anymore.
Change-Id: I594788e322bfd83be1e7847d3272d57c549f3e8b
Aaron Schulz [Tue, 17 Apr 2018 00:11:42 +0000 (17:11 -0700)]
Migrate PurgeJobUtils callback to AutoCommitUpdate
Since it calls LBFactory::commitAndWaitForReplication, blocking for
an unknown amount of time, it is a bit "heavyweight" to be the sort
of quick update that uses onTransactionIdle().
Change-Id: Ic3476de5b61a7cd5f31ba487b186f9605a3b2774
jenkins-bot [Mon, 16 Apr 2018 22:58:47 +0000 (22:58 +0000)]
Merge "resourceloader: Clean up CSSMinTest"
Timo Tijhof [Mon, 16 Apr 2018 22:05:46 +0000 (23:05 +0100)]
resourceloader: Clean up CSSMinTest
* Consistently name data providers as "provide.." and make them
static.
* Document why wgServer is being mocked.
* Use TestingAccessWrapper instead of ad-hoc sub class for
accessing protected methods.
Change-Id: Ife2d98091200bbc8fb16b7ac6eafd3f2c22c1463
Aaron Schulz [Thu, 5 Apr 2018 02:44:21 +0000 (19:44 -0700)]
rdbms: add $flags argument to ILoadBalancer::getAnyOpenConnection
Make LoadMonitor use this flag for getting a connection.
Change-Id: I32ea9aadc0223c86db5979d6579d781a6af0ff53
Translation updater bot [Mon, 16 Apr 2018 19:55:08 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id2377abe03165cfbdf22d0417471efa18af02cde
Max Semenik [Sat, 6 Jan 2018 12:41:37 +0000 (15:41 +0300)]
Restrict shell commands by default
Before it's too late, let's boil the oceans
and just do it. This patch assumes that old code
calling wfShellExec() doesn't know about restrictions
so it doesn't restrict anything. New code, however,
needs to specify its restrictions or deal with defaults.
Change-Id: I58963901087202d4a405bcdb6bd12758bb6b0ff7
Bartosz Dziewoński [Mon, 16 Apr 2018 18:05:12 +0000 (20:05 +0200)]
mw.widgets.visibleLengthLimit: Apply number conversion to the limit
In languages like Persian (fa) or Hindi (hi) this should probably use
localised numerals.
Change-Id: Iba40634038079deba1c26bacb515f4791b4d38db
Thiemo Kreuz [Mon, 16 Apr 2018 17:30:07 +0000 (19:30 +0200)]
Fix bad archive file names in ImportableUploadRevisionImporter
Bug: T176871
Change-Id: I61625a515a8d49dec33af49022506be2e019a23b
jenkins-bot [Mon, 16 Apr 2018 16:57:14 +0000 (16:57 +0000)]
Merge "Deprecate wfShellWikiCmd()"
jenkins-bot [Mon, 16 Apr 2018 16:55:43 +0000 (16:55 +0000)]
Merge "Title: Simplify use of MWNamespace::getCanonicalName()"
Bartosz Dziewoński [Mon, 16 Apr 2018 16:39:24 +0000 (18:39 +0200)]
ImportStreamSource: Replace magic numbers with constants
https://secure.php.net/manual/en/features.file-upload.errors.php
Also improve code comments.
Change-Id: I3bbe02f5cce39352659b33caba10e40afc5fe34a
Max Semenik [Fri, 19 Jan 2018 01:44:03 +0000 (17:44 -0800)]
Deprecate wfShellWikiCmd()
Bug: T184339
Change-Id: Ic86a451e0e9d609e06865a4969560d151efa844c
Kunal Mehta [Mon, 16 Apr 2018 07:06:56 +0000 (00:06 -0700)]
Update wikimedia/utfnormal to 2.0.0
Bug: T188480
Depends-On: I6dc14850ba4dfb0ba237b68337b6a86768739b5b
Change-Id: I5f1fc27d5bb588c15cabb7f1c909c104f6325e96
jenkins-bot [Mon, 16 Apr 2018 03:06:05 +0000 (03:06 +0000)]
Merge "Remove gadget special-case from preferences cleanup"
jenkins-bot [Mon, 16 Apr 2018 01:01:21 +0000 (01:01 +0000)]
Merge "rdbms: make LoadBalancer::doWait() cast $timeout to an integer"
Translation updater bot [Sun, 15 Apr 2018 20:08:59 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8ef3d6d1aaef6a49e92ace4fa3581c17fec2f894
jenkins-bot [Sun, 15 Apr 2018 18:48:10 +0000 (18:48 +0000)]
Merge "tests: Support passing null to setExpectedException() in compat layer"
jenkins-bot [Sun, 15 Apr 2018 18:41:32 +0000 (18:41 +0000)]
Merge "Add release notes for
036f5b47efc99"
jenkins-bot [Sun, 15 Apr 2018 18:38:47 +0000 (18:38 +0000)]
Merge "Add release notes for
8de958444f1d36"
Aryeh Gregor [Sun, 8 Apr 2018 19:00:32 +0000 (22:00 +0300)]
Test ApiMove
One bug caught: the watch and unwatch params were not being honored.
They have now been removed.
Depends-On: Ia21a974f2b463afc9324182137b95c80db86a6aa
Change-Id: I0e214339c9ae3f0fb5a40c88a84190bc32503151
jenkins-bot [Sun, 15 Apr 2018 08:44:34 +0000 (08:44 +0000)]
Merge "phan: Provide stub for wikidiff2_inline_diff()"
Kunal Mehta [Sat, 14 Apr 2018 23:10:24 +0000 (16:10 -0700)]
tests: Support passing null to setExpectedException() in compat layer
PHPUnit 4's setExpectedException() accepted null for the exception class
name to indicate that no exception would be thrown. PHPUnit 6's
expectException() is stricter and only allows strings.
Change-Id: I8c8783faec808a8f111af2ee533f5c61feccf099
Kunal Mehta [Sat, 14 Apr 2018 23:00:28 +0000 (16:00 -0700)]
Add release notes for
036f5b47efc99
Change-Id: Ia25937b3308ed1caeae9e4a5510648c7f6e19586
Kunal Mehta [Sat, 14 Apr 2018 22:40:30 +0000 (15:40 -0700)]
Add release notes for
8de958444f1d36
Change-Id: I5adc2758ca5e61a291139fc4b4a08d686601f285
Translation updater bot [Sat, 14 Apr 2018 19:55:19 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1d1d9da19da9f5a9b282d957232c3adea9219e4d
Kunal Mehta [Sat, 14 Apr 2018 10:54:12 +0000 (03:54 -0700)]
phan: Provide stub for wikidiff2_inline_diff()
Needed by MobileFrontend
Change-Id: I5c6dfae873b5292f26652631943d42de08df49b3
Aaron Schulz [Thu, 29 Mar 2018 02:42:31 +0000 (19:42 -0700)]
rdbms: make LoadBalancer::doWait() cast $timeout to an integer
Make sure that fractional values are not sent to masterPosWait()
Change-Id: I0a66471d4bf7005774b5741702c7f9c65bbfd5d0
jenkins-bot [Sat, 14 Apr 2018 02:39:33 +0000 (02:39 +0000)]
Merge "Use constants for rc_patrolled values instead of numbers"
jenkins-bot [Sat, 14 Apr 2018 02:27:05 +0000 (02:27 +0000)]
Merge "Add an "editor" extension type"
Krinkle [Sat, 14 Apr 2018 00:11:56 +0000 (00:11 +0000)]
Merge "selenium: Remove Jenkins configuration file"
Krinkle [Sat, 14 Apr 2018 00:11:51 +0000 (00:11 +0000)]
Merge "Selenium: move logic for running tests from package.json to selenium.sh"
jenkins-bot [Fri, 13 Apr 2018 23:20:08 +0000 (23:20 +0000)]
Merge "Remove unused $titleObj"
jenkins-bot [Fri, 13 Apr 2018 22:45:57 +0000 (22:45 +0000)]
Merge "LoadBalancerTest: Clean up transaction handling for sqlite"
jenkins-bot [Fri, 13 Apr 2018 22:42:03 +0000 (22:42 +0000)]
Merge "Fix testGetMap_twoValues() failures for sqlite"
Kunal Mehta [Fri, 13 Apr 2018 22:35:07 +0000 (15:35 -0700)]
Add an "editor" extension type
For extensions that provide an editor or enhance the editing experience.
Extensions like CodeEditor, WikiEditor, or VisualEditor could use this type.
Change-Id: Id5714caa492f10b97ea272c2ec181cded60fc47f
Kunal Mehta [Sun, 8 Apr 2018 23:26:01 +0000 (16:26 -0700)]
Handle extension dependencies in the installer
As there will likely be extensions bundled with the 1.31 release that
depend upon other extensions, we should have the installer prevent users
from enabling extensions that depend on other, not-enabled extensions.
We can build a dependency map from extension.json's "requires"
component. On the client-side, we'll first disable all checkboxes that
require other extensions, and evaluate each checkbox click, updating the
disabled checkboxes as possible.
This required some refactoring of how ExtensionRegistry reports issues
with dependency resolution so we could get a list of what was missing.
While we're at it, sort the extensions under headings by type.
This does not support skins that have dependencies yet (T186092).
Bug: T31134
Bug: T55985
Change-Id: I5f0e3b1b540b5ef6f9b8e3fc2bbaad1c65b4b680