Merge "Make User::isBot() also check the "bot" right for sanity"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 12 May 2016 23:13:17 +0000 (23:13 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 12 May 2016 23:13:17 +0000 (23:13 +0000)
1  2 
includes/user/User.php

diff --combined includes/user/User.php
@@@ -127,7 -127,6 +127,7 @@@ class User implements IDBAccessObject 
                'createpage',
                'createtalk',
                'delete',
 +              'deletechangetags',
                'deletedhistory',
                'deletedtext',
                'deletelogentry',
         * @since 1.28
         */
        public function isBot() {
-               $isBot = false;
-               if ( !Hooks::run( "UserIsBot", [ $this, &$isBot ] ) ) {
-                       return $isBot;
+               if ( in_array( 'bot', $this->getGroups() ) && $this->isAllowed( 'bot' ) ) {
+                       return true;
                }
  
-               return ( $isBot || in_array( 'bot', $this->getGroups() ) );
+               $isBot = false;
+               Hooks::run( "UserIsBot", [ $this, &$isBot ] );
+               return $isBot;
        }
  
        /**