From: Sam Reed <reedy@users.mediawiki.org>
Date: Tue, 14 Dec 2010 18:17:42 +0000 (+0000)
Subject: Fixup fixme on r76844
X-Git-Tag: 1.31.0-rc.0~33298
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22articles%22%2C%22id_article=%24id_article%22%29%20.%20%22?a=commitdiff_plain;h=e4a9c89be0afc6936a50e2e1bf04231ac3710bb8;p=lhc%2Fweb%2Fwiklou.git

Fixup fixme on r76844

Only "known issue", is the bottom limit thing posts, and won't override the top one, if it's set one in the URL, which is a PITA. 2 clicks does it. Hopefully this can be fixed, and uncommented when VVV sorts out our queryparameters? :)
---

diff --git a/includes/Pager.php b/includes/Pager.php
index b6956e5309..bf613fdcdc 100644
--- a/includes/Pager.php
+++ b/includes/Pager.php
@@ -1047,20 +1047,26 @@ abstract class TablePager extends IndexPager {
 	function getLimitForm() {
 		global $wgScript;
 
+		return Xml::openElement(
+			'form',
+			array(
+				'method' => 'get',
+				'action' => $wgScript
+			) ) . "\n" . $this->getLimitDropdown() . "</form>\n";
+	}
+
+	/**
+	 * Gets a limit selection dropdown
+	 *
+	 * @return string
+	 */
+	function getLimitDropdown() {
 		# Make the select with some explanatory text
 		$msgSubmit = wfMsgHtml( 'table_pager_limit_submit' );
-		return
-			Xml::openElement(
-				'form',
-				array(
-					'method' => 'get',
-					'action' => $wgScript
-				)
-			) . "\n" .
-			wfMsgHtml( 'table_pager_limit', $this->getLimitSelect() ) .
+
+		return wfMsgHtml( 'table_pager_limit', $this->getLimitSelect() ) .
 			"\n<input type=\"submit\" value=\"$msgSubmit\"/>\n" .
-			$this->getHiddenFields( array( 'limit' ) ) .
-			"</form>\n";
+			$this->getHiddenFields( array( 'limit' ) );
 	}
 
 	/**