From fc202943abbf579898270e1269054906ccfdc4fc Mon Sep 17 00:00:00 2001 From: Stanislav Malyshev Date: Wed, 5 Sep 2018 15:00:25 -0700 Subject: [PATCH] Make assertFileContains not create files by default This makes us miss test bugs like one in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/458305 Change-Id: I2a96ed180be216aa615d8506999aa75f04c267bf Depends-On: Ic85db75c2dba6c1c1fa6fd74dbea64f213609c0d --- tests/phpunit/MediaWikiTestCase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/phpunit/MediaWikiTestCase.php b/tests/phpunit/MediaWikiTestCase.php index 69721655ce..29e98059f5 100644 --- a/tests/phpunit/MediaWikiTestCase.php +++ b/tests/phpunit/MediaWikiTestCase.php @@ -2278,7 +2278,7 @@ abstract class MediaWikiTestCase extends PHPUnit\Framework\TestCase { protected function assertFileContains( $fileName, $actualData, - $createIfMissing = true, + $createIfMissing = false, $msg = '' ) { if ( $createIfMissing ) { -- 2.20.1