From eb8e2ba2340018fc325bbff5de0d020ecfcb96aa Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Thu, 19 Jul 2018 17:35:59 +0200 Subject: [PATCH] test: disable hook when testing default preferences The GetPreferences hook lets extensions register additional user preferences. They show up on the form and that breaks the hardcoded assertion that exactly 5 preferences are available. Disable the hook in case the test is run with extensions loaded in (ex: BetaFeatures). Change-Id: I78b11e989110407cd721e8a3fbbe81d28ca4be5b --- .../includes/preferences/DefaultPreferencesFactoryTest.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php b/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php index 43c678e928..2eec5ce238 100644 --- a/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php +++ b/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php @@ -63,6 +63,8 @@ class DefaultPreferencesFactoryTest extends MediaWikiTestCase { * @covers MediaWiki\Preferences\DefaultPreferencesFactory::getForm() */ public function testGetForm() { + $this->setTemporaryHook( 'GetPreferences', null ); + $testUser = $this->getTestUser(); $form = $this->getPreferencesFactory()->getForm( $testUser->getUser(), $this->context ); $this->assertInstanceOf( PreferencesFormLegacy::class, $form ); -- 2.20.1