From caf66ceb91967c7734435aa2344b448bcd37a482 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Thu, 28 Feb 2019 12:37:40 +0100 Subject: [PATCH] upload: Simplify file extension extraction in UploadBase The code does the exact same, just shorter and hopefully better readable. Change-Id: Idd1d34927a5c027d378d1a54afd23dc7f33ee004 --- includes/upload/UploadBase.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/upload/UploadBase.php b/includes/upload/UploadBase.php index d9e8e99498..d692f1a432 100644 --- a/includes/upload/UploadBase.php +++ b/includes/upload/UploadBase.php @@ -947,8 +947,8 @@ abstract class UploadBase { */ list( $partname, $ext ) = $this->splitExtensions( $this->mFilteredName ); - if ( count( $ext ) ) { - $this->mFinalExtension = trim( $ext[count( $ext ) - 1] ); + if ( $ext !== [] ) { + $this->mFinalExtension = trim( end( $ext ) ); } else { $this->mFinalExtension = ''; -- 2.20.1