From c7c2637bbd3aa296e52171dd09c8effe2b9b28cd Mon Sep 17 00:00:00 2001 From: Jack Phoenix Date: Fri, 29 Mar 2019 19:49:36 +0200 Subject: [PATCH] Use isset() to avoid an E_NOTICE about an undefined index Change-Id: Ida990c474a7e4269dc2df989232eea5cb7b83345 --- includes/media/GIFHandler.php | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/includes/media/GIFHandler.php b/includes/media/GIFHandler.php index 556e83c960..9ef37fbee7 100644 --- a/includes/media/GIFHandler.php +++ b/includes/media/GIFHandler.php @@ -86,8 +86,11 @@ class GIFHandler extends BitmapHandler { $ser = $image->getMetadata(); if ( $ser ) { $metadata = unserialize( $ser ); - - return $image->getWidth() * $image->getHeight() * $metadata['frameCount']; + if ( isset( $metadata['frameCount'] ) && $metadata['frameCount'] > 0 ) { + return $image->getWidth() * $image->getHeight() * $metadata['frameCount']; + } else { + return $image->getWidth() * $image->getHeight(); + } } else { return $image->getWidth() * $image->getHeight(); } @@ -101,7 +104,7 @@ class GIFHandler extends BitmapHandler { $ser = $image->getMetadata(); if ( $ser ) { $metadata = unserialize( $ser ); - if ( $metadata['frameCount'] > 1 ) { + if ( isset( $metadata['frameCount'] ) && $metadata['frameCount'] > 1 ) { return true; } } -- 2.20.1