From a5352157c7209084c85ac1bacc6c4b06f8c423f0 Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sun, 21 Oct 2018 00:47:26 -0700
Subject: [PATCH] Deprecate hacky wfSplitWikiID() method

Change-Id: I59095ee7cc39f634d124fa711ec01a5a5d188d23
---
 RELEASE-NOTES-1.33           | 2 ++
 includes/GlobalFunctions.php | 1 +
 2 files changed, 3 insertions(+)

diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33
index e3bd20810d..999cda8782 100644
--- a/RELEASE-NOTES-1.33
+++ b/RELEASE-NOTES-1.33
@@ -81,6 +81,8 @@ because of Phabricator reports.
 * The LegacyHookPreAuthenticationProvider class, deprecated since its creation
   in 1.27 as part of the AuthManager re-write, now emits deprecation warnings.
   This will help identify the issue if you added it to $wgAuthManagerConfig.
+* wfSplitWikiId() is now deprecated. Cache key generation should have the wiki
+  domain ID as a key component and use makeGlobalKey().
 * …
 
 === Other changes in 1.33 ===
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 4531b5401b..6e95871885 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2656,6 +2656,7 @@ function wfWikiID() {
  * @param string $wiki
  *
  * @return array
+ * @deprecated 1.32
  */
 function wfSplitWikiID( $wiki ) {
 	$bits = explode( '-', $wiki, 2 );
-- 
2.20.1