From a1bb593efb954225f3db5dca6c5879b41a9e344d Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Tue, 12 Feb 2019 12:57:05 +0100 Subject: [PATCH] Add missing documentation to ProtectedTitlesPager This was discussed in I2b5c95d. The reason no IDE was able to find this usage of the deprecated SpecialPage::getTitle method was the missing type hinting. TODO: * A lot of properties this class uses are not declared. * A lot of stuff in here must be private, but is public at the moment. But this is for later patches. Change-Id: I12fd6e517e5bd3507032ee3aafcb1de96733985b --- .../specials/pagers/ProtectedTitlesPager.php | 21 +++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/includes/specials/pagers/ProtectedTitlesPager.php b/includes/specials/pagers/ProtectedTitlesPager.php index 49055af44d..296fe1112d 100644 --- a/includes/specials/pagers/ProtectedTitlesPager.php +++ b/includes/specials/pagers/ProtectedTitlesPager.php @@ -24,8 +24,25 @@ */ class ProtectedTitlesPager extends AlphabeticPager { - public $mForm, $mConds; + /** + * @var SpecialProtectedtitles + */ + public $mForm; + /** + * @var array + */ + public $mConds; + + /** + * @param SpecialProtectedtitles $form + * @param array $conds + * @param string|null $type + * @param string|null $level + * @param int|null $namespace + * @param string|null $sizetype + * @param int|null $size + */ public function __construct( $form, $conds, $type, $level, $namespace, $sizetype = '', $size = 0 ) { @@ -55,7 +72,7 @@ class ProtectedTitlesPager extends AlphabeticPager { * @return Title */ function getTitle() { - return $this->mForm->getTitle(); + return $this->mForm->getPageTitle(); } function formatRow( $row ) { -- 2.20.1