From 92602fefda8a14b04e32ac12f279d4b47a5b5f23 Mon Sep 17 00:00:00 2001 From: Ori Livneh Date: Tue, 25 Aug 2015 18:13:14 -0700 Subject: [PATCH] Micro-optimize Language::isMultiByte() The xenon logs on performance.wikimedia.org show this function as being on-CPU about 1% of the time, making it a candidate for optimization. The version in this patch is about 30-50% faster in my benchmarks. Change-Id: I26385ade7600fc11965d94468b57e41ec257de51 --- languages/Language.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/languages/Language.php b/languages/Language.php index b698bebf43..370e2ed8c8 100644 --- a/languages/Language.php +++ b/languages/Language.php @@ -2838,7 +2838,7 @@ class Language { * @return bool */ function isMultibyte( $str ) { - return (bool)preg_match( '/[\x80-\xff]/', $str ); + return strlen( $str ) !== mb_strlen( $str ); } /** -- 2.20.1