From 81319eb28d7538d12ff6bc661746b909e5c9c6d9 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 22 Jan 2015 16:35:26 -0800 Subject: [PATCH] mediawiki.cookie: Remove false documentation for options.expiry as number Follows-up 7c585b5. There was never an implementation for supporting an offset from now in seconds. The code and tests account for no such thing. When passed a number, it will actually end up being passed to $.cookie, which interprets it as an offset in days (!). Change-Id: I5d8ed8cb432ca550c62cf415077ffffd91fe2bbd --- resources/src/mediawiki/mediawiki.cookie.js | 3 +-- .../qunit/suites/resources/mediawiki/mediawiki.cookie.test.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.cookie.js b/resources/src/mediawiki/mediawiki.cookie.js index 6f9f0abb46..1b86b61255 100644 --- a/resources/src/mediawiki/mediawiki.cookie.js +++ b/resources/src/mediawiki/mediawiki.cookie.js @@ -30,8 +30,7 @@ * @param {Date|null} [options.expires=wgCookieExpiration] The expiry date of the cookie. * * Default cookie expiration is based on `wgCookieExpiration`. If `wgCookieExpiration` is - * 0, a session cookie is set (expires when the browser is closed). For non-zero values of - * `wgCookieExpiration`, the cookie expires `wgCookieExpiration` seconds from now. + * 0, a session cookie is set (expires when the browser is closed). * * If options.expires is null, then a session cookie is set. * @param {string} [options.prefix=wgCookiePrefix] The prefix of the key diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.cookie.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.cookie.test.js index c9653dabc0..c6aa3b71aa 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.cookie.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.cookie.test.js @@ -169,4 +169,4 @@ assert.strictEqual( key, 'barfoo' ); } ); -} ( mediaWiki, jQuery ) ); +}( mediaWiki, jQuery ) ); -- 2.20.1