From: Kosta Harlan <kharlan@wikimedia.org>
Date: Fri, 4 Jan 2019 21:33:45 +0000 (-0500)
Subject: Make ContribsPager properties private again
X-Git-Tag: 1.34.0-rc.0~3139^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_aide%28?a=commitdiff_plain;h=a6cb793e251914c741a5a4fbf7db16cbd0e3f8fd;p=lhc%2Fweb%2Fwiklou.git

Make ContribsPager properties private again

Bug: T212771
Follows-Up: I2295a3fefe874a59458e6ea7edd2cfdd9e912096
Depends-On: I847cb6863be2b6b196b2a992c3dde13e0b21462a
Change-Id: I6b7d0c502ab0219de1b04c8e78e4aaffe43ea0d0
---

diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php
index 5112ccdefe..1220e8617a 100644
--- a/includes/specials/pagers/ContribsPager.php
+++ b/includes/specials/pagers/ContribsPager.php
@@ -37,32 +37,24 @@ class ContribsPager extends RangeChronologicalPager {
 
 	/**
 	 * @var string User name, or a string describing an IP address range
-	 * @private
-	 * @fixme Make private again after Flow got fixed.
 	 */
-	public $target;
+	private $target;
 
 	/**
 	 * @var string Set to "newbie" to list contributions from the most recent 1% registered users.
 	 *  $this->target is ignored then. Defaults to "users".
-	 * @private
-	 * @fixme Make private again after Flow got fixed.
 	 */
-	public $contribs;
+	private $contribs;
 
 	/**
 	 * @var string|int A single namespace number, or an empty string for all namespaces
-	 * @private
-	 * @fixme Make private again after Flow got fixed.
 	 */
-	public $namespace = '';
+	private $namespace = '';
 
 	/**
 	 * @var string|false Name of tag to filter, or false to ignore tags
-	 * @private
-	 * @fixme Make private again after Flow got fixed.
 	 */
-	public $tagFilter;
+	private $tagFilter;
 
 	/**
 	 * @var bool Set to true to invert the namespace selection
@@ -87,10 +79,8 @@ class ContribsPager extends RangeChronologicalPager {
 
 	/**
 	 * @var bool Set to true to show only new pages
-	 * @private
-	 * @fixme Make private again after Flow got fixed.
 	 */
-	public $newOnly;
+	private $newOnly;
 
 	/**
 	 * @var bool Set to true to hide edits marked as minor by the user