From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Tue, 12 Feb 2019 11:57:05 +0000 (+0100)
Subject: Add missing documentation to ProtectedTitlesPager
X-Git-Tag: 1.34.0-rc.0~2828^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_aide%28?a=commitdiff_plain;h=a1bb593efb954225f3db5dca6c5879b41a9e344d;p=lhc%2Fweb%2Fwiklou.git

Add missing documentation to ProtectedTitlesPager

This was discussed in I2b5c95d. The reason no IDE was able to find this
usage of the deprecated SpecialPage::getTitle method was the missing
type hinting.

TODO:
* A lot of properties this class uses are not declared.
* A lot of stuff in here must be private, but is public at the moment.
But this is for later patches.

Change-Id: I12fd6e517e5bd3507032ee3aafcb1de96733985b
---

diff --git a/includes/specials/pagers/ProtectedTitlesPager.php b/includes/specials/pagers/ProtectedTitlesPager.php
index 49055af44d..296fe1112d 100644
--- a/includes/specials/pagers/ProtectedTitlesPager.php
+++ b/includes/specials/pagers/ProtectedTitlesPager.php
@@ -24,8 +24,25 @@
  */
 class ProtectedTitlesPager extends AlphabeticPager {
 
-	public $mForm, $mConds;
+	/**
+	 * @var SpecialProtectedtitles
+	 */
+	public $mForm;
 
+	/**
+	 * @var array
+	 */
+	public $mConds;
+
+	/**
+	 * @param SpecialProtectedtitles $form
+	 * @param array $conds
+	 * @param string|null $type
+	 * @param string|null $level
+	 * @param int|null $namespace
+	 * @param string|null $sizetype
+	 * @param int|null $size
+	 */
 	public function __construct( $form, $conds, $type, $level, $namespace,
 		$sizetype = '', $size = 0
 	) {
@@ -55,7 +72,7 @@ class ProtectedTitlesPager extends AlphabeticPager {
 	 * @return Title
 	 */
 	function getTitle() {
-		return $this->mForm->getTitle();
+		return $this->mForm->getPageTitle();
 	}
 
 	function formatRow( $row ) {