From: Chad Horohoe <chadh@wikimedia.org>
Date: Wed, 19 Mar 2014 16:35:23 +0000 (-0700)
Subject: Remove completely useless implementation of getInfo()
X-Git-Tag: 1.31.0-rc.0~16542^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_aide%28?a=commitdiff_plain;h=692257f959f31872394abd15fbddef38ea1e4198;p=lhc%2Fweb%2Fwiklou.git

Remove completely useless implementation of getInfo()

Embedding random strings in Special:Search's comments doesn't
help debugging and just increases page size.

Bug: 62768
Change-Id: I51270aa3f2cba921841e2d8ebbd4fa665542f8a9
---

diff --git a/includes/search/SearchResultSet.php b/includes/search/SearchResultSet.php
index 3c6c8d055f..e6893892ce 100644
--- a/includes/search/SearchResultSet.php
+++ b/includes/search/SearchResultSet.php
@@ -88,16 +88,6 @@ class SearchResultSet {
 		return '';
 	}
 
-	/**
-	 * Return information about how and from where the results were fetched,
-	 * should be useful for diagnostics and debugging
-	 *
-	 * @return String
-	 */
-	function getInfo() {
-		return null;
-	}
-
 	/**
 	 * Return a result set of hits on other (multiple) wikis associated with this one
 	 *
diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php
index 3659c48ab9..ffe88f7aec 100644
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -538,12 +538,7 @@ class SpecialSearch extends SpecialPage {
 
 		$terms = $wgContLang->convertForSearchResult( $matches->termMatches() );
 
-		$out = "";
-		$infoLine = $matches->getInfo();
-		if ( !is_null( $infoLine ) ) {
-			$out .= "\n<!-- {$infoLine} -->\n";
-		}
-		$out .= "<ul class='mw-search-results'>\n";
+		$out = "<ul class='mw-search-results'>\n";
 		$result = $matches->next();
 		while ( $result ) {
 			$out .= $this->showHit( $result, $terms );