From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Tue, 14 Jun 2016 13:42:15 +0000 (-0400)
Subject: Don't misname login button
X-Git-Tag: 1.31.0-rc.0~6620
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_aide%28?a=commitdiff_plain;h=6704d8571808119b94e60b41188cdbdfd06bad9c;p=lhc%2Fweb%2Fwiklou.git

Don't misname login button

Particularly don't name it "wpRemember", which is the name of a
completely different field.

Bug: T137799
Change-Id: I4b5f79ec59edf33b3ec91f019bf08ef5507ed55b
---

diff --git a/includes/specialpage/LoginSignupSpecialPage.php b/includes/specialpage/LoginSignupSpecialPage.php
index 3099a9b0bb..eb1c805e99 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1025,6 +1025,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
 				'rememberMe' => [
 					// option for saving the user token to a cookie
 					'type' => 'check',
+					'name' => 'wpRemember',
 					'label-message' => $this->msg( 'userlogin-remembermypassword' )
 						->numParams( $expirationDays ),
 					'id' => 'wpRemember',
@@ -1032,7 +1033,6 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
 				'loginattempt' => [
 					// submit button
 					'type' => 'submit',
-					'name' => 'wpRemember',
 					'default' => $this->msg( 'pt-login-' . $continuePart . 'button' )->text(),
 					'id' => 'wpLoginAttempt',
 					'weight' => 100,