dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ff22b6a) | patch
RCFilters: Remove isAllowedCallable and isAllowed
authorMatthew Flaschen <mflaschen@wikimedia.org>
Fri, 31 Mar 2017 05:07:31 +0000 (01:07 -0400)
committerMatthew Flaschen <mflaschen@wikimedia.org>
Fri, 31 Mar 2017 05:49:44 +0000 (01:49 -0400)
commitcf463a40599948928fec4f01aabff9c0c3a8ec44
tree5441a32fcda59c44f67fbdbab6e60faa421d45d3tree | snapshot
parentff22b6aff884be436a2620973f40b12b03a5a2c7commit | diff
RCFilters: Remove isAllowedCallable and isAllowed

This is pretty fragile; it's easy to accidentally miss one of the
checks (as has already happened in e.g. parseParameters).

Although I don't yet know of any bugs as a result of this, it's
cleaner to do it at registration time.

There are no extensions using this feature.

Change-Id: I8547ea6432cae73e1bc272dbe959f2415b8a6d21
13 files changed:
includes/changes/ChangesListBooleanFilter.php diff | blob | history
includes/changes/ChangesListFilter.php diff | blob | history
includes/changes/ChangesListFilterGroup.php diff | blob | history
includes/changes/ChangesListStringOptionsFilter.php diff | blob | history
includes/changes/ChangesListStringOptionsFilterGroup.php diff | blob | history
includes/specialpage/ChangesListSpecialPage.php diff | blob | history
includes/specials/SpecialRecentchanges.php diff | blob | history
includes/specials/SpecialWatchlist.php diff | blob | history
tests/phpunit/includes/changes/ChangesListBooleanFilterGroupTest.php diff | blob | history
tests/phpunit/includes/changes/ChangesListBooleanFilterTest.php diff | blob | history
tests/phpunit/includes/changes/ChangesListStringOptionsFilterGroupTest.php diff | blob | history
tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php diff | blob | history
tests/phpunit/mocks/MockChangesListFilter.php diff | blob | history
Wiklou, le Wiki du Wiklou