From 98a0e7d68b3a56268b72f5eba271babef064fd1a Mon Sep 17 00:00:00 2001
From: addshore <addshorewiki@gmail.com>
Date: Thu, 24 Oct 2013 19:04:38 +0100
Subject: [PATCH] @covers tags for the rest of /media/* tests

Change-Id: I12879baf7810648d3ec0789feac5af364d5696f7
---
 tests/phpunit/includes/media/FormatMetadataTest.php       | 6 +++---
 .../phpunit/includes/media/JpegMetadataExtractorTest.php  | 3 ++-
 tests/phpunit/includes/media/JpegTest.php                 | 4 +++-
 tests/phpunit/includes/media/PNGMetadataExtractorTest.php | 2 +-
 tests/phpunit/includes/media/SVGMetadataExtractorTest.php | 2 +-
 tests/phpunit/includes/media/XMPTest.php                  | 8 ++++++++
 6 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/tests/phpunit/includes/media/FormatMetadataTest.php b/tests/phpunit/includes/media/FormatMetadataTest.php
index a073e4ca6b..a8e420f097 100644
--- a/tests/phpunit/includes/media/FormatMetadataTest.php
+++ b/tests/phpunit/includes/media/FormatMetadataTest.php
@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @todo covers tags
- */
 class FormatMetadataTest extends MediaWikiTestCase {
 
 	/** @var FSFileBackend */
@@ -31,6 +28,9 @@ class FormatMetadataTest extends MediaWikiTestCase {
 		$this->setMwGlobals( 'wgShowEXIF', true );
 	}
 
+	/**
+	 * @covers File::formatMetadata
+	 */
 	public function testInvalidDate() {
 		$file = $this->dataFile( 'broken_exif_date.jpg', 'image/jpeg' );
 
diff --git a/tests/phpunit/includes/media/JpegMetadataExtractorTest.php b/tests/phpunit/includes/media/JpegMetadataExtractorTest.php
index eafc8a2e5f..6d1d681bc1 100644
--- a/tests/phpunit/includes/media/JpegMetadataExtractorTest.php
+++ b/tests/phpunit/includes/media/JpegMetadataExtractorTest.php
@@ -5,7 +5,8 @@
  * serve as a very good "test". (Adobe photoshop probably creates such files
  * but it costs money). The implementation of it currently in MediaWiki is based
  * solely on reading the standard, without any real world test files.
- * @todo covers tags
+ *
+ * @covers JpegMetadataExtractor
  */
 class JpegMetadataExtractorTest extends MediaWikiTestCase {
 
diff --git a/tests/phpunit/includes/media/JpegTest.php b/tests/phpunit/includes/media/JpegTest.php
index 9af4f1e1bd..ce956baf4b 100644
--- a/tests/phpunit/includes/media/JpegTest.php
+++ b/tests/phpunit/includes/media/JpegTest.php
@@ -1,9 +1,11 @@
 <?php
 /**
- * @todo covers tags
+ * @covers JpegHandler
  */
 class JpegTest extends MediaWikiTestCase {
 
+	protected $filePath;
+
 	protected function setUp() {
 		parent::setUp();
 		if ( !extension_loaded( 'exif' ) ) {
diff --git a/tests/phpunit/includes/media/PNGMetadataExtractorTest.php b/tests/phpunit/includes/media/PNGMetadataExtractorTest.php
index 939f2cfc07..33a03a2e0c 100644
--- a/tests/phpunit/includes/media/PNGMetadataExtractorTest.php
+++ b/tests/phpunit/includes/media/PNGMetadataExtractorTest.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * @todo covers tags
+ * @covers PNGMetadataExtractor
  */
 class PNGMetadataExtractorTest extends MediaWikiTestCase {
 
diff --git a/tests/phpunit/includes/media/SVGMetadataExtractorTest.php b/tests/phpunit/includes/media/SVGMetadataExtractorTest.php
index 257009b02a..5dd7b2425a 100644
--- a/tests/phpunit/includes/media/SVGMetadataExtractorTest.php
+++ b/tests/phpunit/includes/media/SVGMetadataExtractorTest.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * @todo covers tags
+ * @covers SVGMetadataExtractor
  */
 class SVGMetadataExtractorTest extends MediaWikiTestCase {
 
diff --git a/tests/phpunit/includes/media/XMPTest.php b/tests/phpunit/includes/media/XMPTest.php
index d12e9b00a6..9ec5796dd3 100644
--- a/tests/phpunit/includes/media/XMPTest.php
+++ b/tests/phpunit/includes/media/XMPTest.php
@@ -21,6 +21,8 @@ class XMPTest extends MediaWikiTestCase {
 	 *
 	 * @throws Exception
 	 * @dataProvider provideXMPParse
+	 *
+	 * @covers XMPReader::parse
 	 */
 	public function testXMPParse( $xmp, $expected, $info ) {
 		if ( !is_string( $xmp ) || !is_array( $expected ) ) {
@@ -79,6 +81,8 @@ class XMPTest extends MediaWikiTestCase {
 	 *
 	 * @todo This is based on what the standard says. Need to find a real
 	 * world example file to double check the support for this is right.
+	 *
+	 * @covers XMPReader::parseExtended
 	 */
 	public function testExtendedXMP() {
 		$xmpPath = __DIR__ . '/../../data/xmp/';
@@ -109,6 +113,8 @@ class XMPTest extends MediaWikiTestCase {
 	/**
 	 * This test has an extended XMP block with a wrong guid (md5sum)
 	 * and thus should only return the StandardXMP, not the ExtendedXMP.
+	 *
+	 * @covers XMPReader::parseExtended
 	 */
 	public function testExtendedXMPWithWrongGUID() {
 		$xmpPath = __DIR__ . '/../../data/xmp/';
@@ -138,6 +144,8 @@ class XMPTest extends MediaWikiTestCase {
 	/**
 	 * Have a high offset to simulate a missing packet,
 	 * which should cause it to ignore the ExtendedXMP packet.
+	 *
+	 * @covers XMPReader::parseExtended
 	 */
 	public function testExtendedXMPMissingPacket() {
 		$xmpPath = __DIR__ . '/../../data/xmp/';
-- 
2.20.1