From: umherirrender <umherirrender_de.wp@web.de>
Date: Mon, 10 Aug 2015 19:01:59 +0000 (+0200)
Subject: Don't add a link to Special:RecentChanges when tag filter is disabled
X-Git-Tag: 1.31.0-rc.0~10433^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_aide%28?a=commitdiff_plain;h=c7b00168d6c9fbadccb260ed49df4867644f9d44;p=lhc%2Fweb%2Fwiklou.git

Don't add a link to Special:RecentChanges when tag filter is disabled

When wgUseTagFilter = false there is no need to link to
Special:RecentChanges because the special page cannot display the tag
filter and will show all changes, which is wrong.

Bug: T105650
Change-Id: I389aba9cb2862df3ba6980333c5cc94bb30dc202
---

diff --git a/includes/specials/SpecialTags.php b/includes/specials/SpecialTags.php
index a6847e19d1..70eee9f0ae 100644
--- a/includes/specials/SpecialTags.php
+++ b/includes/specials/SpecialTags.php
@@ -216,15 +216,17 @@ class SpecialTags extends SpecialPage {
 		$newRow .= Xml::tags( 'td', null, $this->msg( $activeMsg )->escaped() );
 
 		$hitcountLabel = $this->msg( 'tags-hitcount' )->numParams( $hitcount )->escaped();
-		$hitcountLink = Linker::link(
-			SpecialPage::getTitleFor( 'Recentchanges' ),
-			$hitcountLabel,
-			array(),
-			array( 'tagfilter' => $tag )
-		);
+		if ( $this->getConfig()->get( 'UseTagFilter' ) ) {
+			$hitcountLabel = Linker::link(
+				SpecialPage::getTitleFor( 'Recentchanges' ),
+				$hitcountLabel,
+				array(),
+				array( 'tagfilter' => $tag )
+			);
+		}
 
 		// add raw $hitcount for sorting, because tags-hitcount contains numbers and letters
-		$newRow .= Xml::tags( 'td', array( 'data-sort-value' => $hitcount ), $hitcountLink );
+		$newRow .= Xml::tags( 'td', array( 'data-sort-value' => $hitcount ), $hitcountLabel );
 
 		// actions
 		if ( $showActions ) { // we've already checked that the user had the requisite userright