dépôts
/
lhc
/
web
/
wiklou.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
272e090
)
Remove old workaround for HHVM
author
Max Semenik
<maxsem.wiki@gmail.com>
Fri, 13 Oct 2017 00:38:34 +0000
(17:38 -0700)
committer
Max Semenik
<maxsem.wiki@gmail.com>
Fri, 13 Oct 2017 00:38:34 +0000
(17:38 -0700)
The bug in question was fixed in HHVM 3.6.0, our minimum requirement is 3.6.5.
Change-Id: Id1d65cf438c7148064d747f09728ef4cb5f51b52
maintenance/Maintenance.php
patch
|
blob
|
history
diff --git
a/maintenance/Maintenance.php
b/maintenance/Maintenance.php
index
ecbbb85
..
4ad6e6e
100644
(file)
--- a/
maintenance/Maintenance.php
+++ b/
maintenance/Maintenance.php
@@
-1444,13
+1444,7
@@
abstract class Maintenance {
}
if ( $isatty && function_exists( 'readline' ) ) {
- $resp = readline( $prompt );
- if ( $resp === null ) {
- // Workaround for https://github.com/facebook/hhvm/issues/4776
- return false;
- } else {
- return $resp;
- }
+ return readline( $prompt );
} else {
if ( $isatty ) {
$st = self::readlineEmulation( $prompt );