Merge "RCFilters: Make sure single_option always has 1 item selected"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 21 Jul 2017 00:34:16 +0000 (00:34 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 21 Jul 2017 00:34:16 +0000 (00:34 +0000)
resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js

index 06fa0aa..a30ebbf 100644 (file)
                // Check if there are either any selected items or any items
                // that have highlight enabled
                return !this.getItems().some( function ( filterItem ) {
-                       return filterItem.isSelected() || filterItem.isHighlighted();
+                       return !filterItem.getGroupModel().isHidden() && ( filterItem.isSelected() || filterItem.isHighlighted() );
                } );
        };