From 738299fa3f78725a65e882ba2270802de368fa85 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 12 Jan 2018 19:25:58 +0000 Subject: [PATCH] config: Increase coverage of EtcdConfig::parseDirectory() One of the error cases wasn't covered yet. Change-Id: I762b37c7448c0f689248a99bad0b206d7cf63d73 --- .../includes/config/EtcdConfigTest.php | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/phpunit/includes/config/EtcdConfigTest.php b/tests/phpunit/includes/config/EtcdConfigTest.php index 7a4d9d9f6f..379eebd8a4 100644 --- a/tests/phpunit/includes/config/EtcdConfigTest.php +++ b/tests/phpunit/includes/config/EtcdConfigTest.php @@ -461,6 +461,26 @@ class EtcdConfigTest extends PHPUnit_Framework_TestCase { false // retry ], ], + '200 OK - Directory with non-array "nodes" key' => [ + 'http' => [ + 'code' => 200, + 'reason' => 'OK', + 'headers' => [], + 'body' => json_encode( [ 'node' => [ 'nodes' => [ + [ + 'key' => '/example/a', + 'dir' => true, + 'nodes' => 'not an array' + ], + ] ] ] ), + 'error' => '', + ], + 'expect' => [ + null, + "Unexpected JSON response in dir 'a'; 'nodes' is not an array.", + false // retry + ], + ], '200 OK - Correctly encoded garbage response' => [ 'http' => [ 'code' => 200, -- 2.20.1