The one-var rule only applies to 'var' where it matters that we
don't let the engine implicitly hoist variables leading to
confusing code that may be unsafe to refactor in a straight-forward
manner.
This doesn't apply to ES6 const and let. While I updated the
rule in
1955a8aa5 to allow ES6, I did not enforce it. Fixed now.
When assigning a value, each assignment should be its own
statement (disallow awkward comma separated assignments).
When not assigning a value, and the lines are next to each other,
they should be in one statement. This makes sense for this small
directory and might make sense to propose for the wikimedia preset
at some point.
Note that the rule I added was not required to make the build
pass. The changes I made are allowed by default by the wikimedia
preset for es6+. The rule I added disallows the previous way.
Change-Id: I26cda095a8a4589084e36273038877f2dd1fc50b
"mw": false
},
"rules": {
- "no-console": "off",
- "prefer-template": "off"
+ "prefer-template": "off",
+ "one-var": [ "error", { "initialized": "never", "uninitialized": "always" } ]
}
}
-const Page = require( 'wdio-mediawiki/Page' ),
- Api = require( 'wdio-mediawiki/Api' ),
- Util = require( 'wdio-mediawiki/Util' );
+const Page = require( 'wdio-mediawiki/Page' );
+const Api = require( 'wdio-mediawiki/Api' );
+const Util = require( 'wdio-mediawiki/Util' );
class HistoryPage extends Page {
get heading() { return $( '#firstHeading' ); }
-const assert = require( 'assert' ),
- Api = require( 'wdio-mediawiki/Api' ),
- DeletePage = require( '../pageobjects/delete.page' ),
- RestorePage = require( '../pageobjects/restore.page' ),
- EditPage = require( '../pageobjects/edit.page' ),
- HistoryPage = require( '../pageobjects/history.page' ),
- UndoPage = require( '../pageobjects/undo.page' ),
- UserLoginPage = require( 'wdio-mediawiki/LoginPage' ),
- Util = require( 'wdio-mediawiki/Util' );
+const assert = require( 'assert' );
+const Api = require( 'wdio-mediawiki/Api' );
+const DeletePage = require( '../pageobjects/delete.page' );
+const RestorePage = require( '../pageobjects/restore.page' );
+const EditPage = require( '../pageobjects/edit.page' );
+const HistoryPage = require( '../pageobjects/history.page' );
+const UndoPage = require( '../pageobjects/undo.page' );
+const UserLoginPage = require( 'wdio-mediawiki/LoginPage' );
+const Util = require( 'wdio-mediawiki/Util' );
describe( 'Page', function () {
- var content, name, bot;
+ let content, name, bot;
before( async function () {
bot = await Api.bot();
-const assert = require( 'assert' ),
- HistoryPage = require( '../pageobjects/history.page' ),
- UserLoginPage = require( 'wdio-mediawiki/LoginPage' ),
- Util = require( 'wdio-mediawiki/Util' );
+const assert = require( 'assert' );
+const HistoryPage = require( '../pageobjects/history.page' );
+const UserLoginPage = require( 'wdio-mediawiki/LoginPage' );
+const Util = require( 'wdio-mediawiki/Util' );
describe( 'Rollback with confirmation', function () {
- var content,
- name;
+ let content, name;
before( function () {
browser.deleteAllCookies();
} );
it.skip( 'should verify rollbacks via GET requests are confirmed on a follow-up page', function () {
- var rollbackActionUrl = HistoryPage.rollbackLink.getAttribute( 'href' );
+ const rollbackActionUrl = HistoryPage.rollbackLink.getAttribute( 'href' );
browser.url( rollbackActionUrl );
browser.waitUntil( function () {
} );
describe( 'Rollback without confirmation', function () {
- var content,
- name;
+ let content, name;
before( function () {
browser.deleteAllCookies();
} );
it.skip( 'should perform rollback via GET request without asking the user to confirm', function () {
- var rollbackActionUrl = HistoryPage.rollbackLink.getAttribute( 'href' );
+ const rollbackActionUrl = HistoryPage.rollbackLink.getAttribute( 'href' );
browser.url( rollbackActionUrl );
browser.waitUntil( function () {
-const assert = require( 'assert' ),
- Api = require( 'wdio-mediawiki/Api' ),
- RecentChangesPage = require( '../pageobjects/recentchanges.page' ),
- Util = require( 'wdio-mediawiki/Util' );
+const assert = require( 'assert' );
+const Api = require( 'wdio-mediawiki/Api' );
+const RecentChangesPage = require( '../pageobjects/recentchanges.page' );
+const Util = require( 'wdio-mediawiki/Util' );
describe( 'Special:RecentChanges', function () {
- let content,
- name;
+ let content, name;
beforeEach( function () {
browser.deleteAllCookies();
-const assert = require( 'assert' ),
- Api = require( 'wdio-mediawiki/Api' ),
- WatchlistPage = require( '../pageobjects/watchlist.page' ),
- WatchablePage = require( '../pageobjects/watchable.page' ),
- LoginPage = require( 'wdio-mediawiki/LoginPage' ),
- Util = require( 'wdio-mediawiki/Util' );
+const assert = require( 'assert' );
+const Api = require( 'wdio-mediawiki/Api' );
+const WatchlistPage = require( '../pageobjects/watchlist.page' );
+const WatchablePage = require( '../pageobjects/watchable.page' );
+const LoginPage = require( 'wdio-mediawiki/LoginPage' );
+const Util = require( 'wdio-mediawiki/Util' );
describe( 'Special:Watchlist', function () {
let username, password;
-const assert = require( 'assert' ),
- CreateAccountPage = require( '../pageobjects/createaccount.page' ),
- PreferencesPage = require( '../pageobjects/preferences.page' ),
- UserLoginPage = require( 'wdio-mediawiki/LoginPage' ),
- Api = require( 'wdio-mediawiki/Api' ),
- Util = require( 'wdio-mediawiki/Util' );
+const assert = require( 'assert' );
+const CreateAccountPage = require( '../pageobjects/createaccount.page' );
+const PreferencesPage = require( '../pageobjects/preferences.page' );
+const UserLoginPage = require( 'wdio-mediawiki/LoginPage' );
+const Api = require( 'wdio-mediawiki/Api' );
+const Util = require( 'wdio-mediawiki/Util' );
describe( 'User', function () {
- var password,
- username;
+ let password, username;
beforeEach( function () {
browser.deleteAllCookies();
-const MWBot = require( 'mwbot' ),
- Page = require( './Page' ),
- MAINPAGE_REQUESTS_MAX_RUNS = 10; // (arbitrary) safe-guard against endless execution
+const MWBot = require( 'mwbot' );
+const Page = require( './Page' );
+const MAINPAGE_REQUESTS_MAX_RUNS = 10; // (arbitrary) safe-guard against endless execution
function getJobCount() {
const bot = new MWBot( {
-const assert = require( 'assert' ),
- BlankPage = require( './../BlankPage' );
+const assert = require( 'assert' );
+const BlankPage = require( './../BlankPage' );
describe( 'BlankPage', function () {
it( 'should have its title @daily', function () {
-const fs = require( 'fs' ),
- path = require( 'path' ),
- startChromedriver = !process.argv.includes( '--skip-chromedriver' ),
- logPath = process.env.LOG_DIR || path.join( __dirname, '/log' );
+/* eslint-disable no-console */
+const fs = require( 'fs' );
+const path = require( 'path' );
+const startChromedriver = !process.argv.includes( '--skip-chromedriver' );
+const logPath = process.env.LOG_DIR || path.join( __dirname, '/log' );
let ffmpeg;