From f9dea337b7f88175b32f086139671548e9b9f485 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Sat, 22 Jul 2006 18:32:53 +0000 Subject: [PATCH] Compare page title with $wgUser->getTitleKey() not $wgUser->getName(). New talk notifications were being erroneously inserted when a user with spaces in their name edited their own user talk page. Bug had been present for at least 18 months, hidden by the fact that the subsequent page view clears the notification. --- includes/Article.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Article.php b/includes/Article.php index f5d1de60d9..3d6460f395 100644 --- a/includes/Article.php +++ b/includes/Article.php @@ -2147,7 +2147,7 @@ class Article { # If this is another user's talk page, update newtalk # Don't do this if $changed = false otherwise some idiot can null-edit a # load of user talk pages and piss people off - if( $this->mTitle->getNamespace() == NS_USER_TALK && $shortTitle != $wgUser->getName() && $changed ) { + if( $this->mTitle->getNamespace() == NS_USER_TALK && $shortTitle != $wgUser->getTitleKey() && $changed ) { if (wfRunHooks('ArticleEditUpdateNewTalk', array(&$this)) ) { $other = User::newFromName( $shortTitle ); if( is_null( $other ) && User::isIP( $shortTitle ) ) { -- 2.20.1