From f739fca0555f3e1c68ff3b7661b66b3f2c9b7ed2 Mon Sep 17 00:00:00 2001
From: Timo Tijhof <krinklemail@gmail.com>
Date: Thu, 29 Oct 2015 01:02:58 +0000
Subject: [PATCH] Language: Remove logic for class file inclusion

* Remove strcspn() check in newFromCode already in isValidCode().
* Leverage the autoloader instead via class_exists instead of
  including files based on user input.
* Create fallback instance directly instead of recursing back
  into newFromCode().

* Remove method preloadLanguageClass (unused).
* Remove method getClassFileName (unused)

Change-Id: I90035ca4b07facae051b1a584e92df72b42c4a49
---
 languages/Language.php | 110 +++++++++++++++--------------------------
 1 file changed, 39 insertions(+), 71 deletions(-)

diff --git a/languages/Language.php b/languages/Language.php
index 3ea2693598..c7871c1bd2 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -207,10 +207,7 @@ class Language {
 	 * @return Language
 	 */
 	protected static function newFromCode( $code ) {
-		// Protect against path traversal below
-		if ( !Language::isValidCode( $code )
-			|| strcspn( $code, ":/\\\000" ) !== strlen( $code )
-		) {
+		if ( !Language::isValidCode( $code ) ) {
 			throw new MWException( "Invalid language code \"$code\"" );
 		}
 
@@ -224,7 +221,6 @@ class Language {
 
 		// Check if there is a language class for the code
 		$class = self::classFromCode( $code );
-		self::preloadLanguageClass( $class );
 		if ( class_exists( $class ) ) {
 			$lang = new $class;
 			return $lang;
@@ -238,9 +234,8 @@ class Language {
 			}
 
 			$class = self::classFromCode( $fallbackCode );
-			self::preloadLanguageClass( $class );
 			if ( class_exists( $class ) ) {
-				$lang = Language::newFromCode( $fallbackCode );
+				$lang = new $class;
 				$lang->setCode( $code );
 				return $lang;
 			}
@@ -341,17 +336,16 @@ class Language {
 	 */
 	public static function isValidCode( $code ) {
 		static $cache = array();
-		if ( isset( $cache[$code] ) ) {
-			return $cache[$code];
+		if ( !isset( $cache[$code] ) ) {
+			// People think language codes are html safe, so enforce it.
+			// Ideally we should only allow a-zA-Z0-9-
+			// but, .+ and other chars are often used for {{int:}} hacks
+			// see bugs 37564, 37587, 36938
+			$cache[$code] =
+				// Protect against path traversal
+				strcspn( $code, ":/\\\000&<>'\"" ) === strlen( $code )
+				&& !preg_match( MediaWikiTitleCodec::getTitleInvalidRegex(), $code );
 		}
-		// People think language codes are html safe, so enforce it.
-		// Ideally we should only allow a-zA-Z0-9-
-		// but, .+ and other chars are often used for {{int:}} hacks
-		// see bugs 37564, 37587, 36938
-		$cache[$code] =
-			strcspn( $code, ":/\\\000&<>'\"" ) === strlen( $code )
-			&& !preg_match( MediaWikiTitleCodec::getTitleInvalidRegex(), $code );
-
 		return $cache[$code];
 	}
 
@@ -411,35 +405,6 @@ class Language {
 		return false;
 	}
 
-	/**
-	 * @param string $code
-	 * @return string Name of the language class
-	 */
-	public static function classFromCode( $code ) {
-		if ( $code == 'en' ) {
-			return 'Language';
-		} else {
-			return 'Language' . str_replace( '-', '_', ucfirst( $code ) );
-		}
-	}
-
-	/**
-	 * Includes language class files
-	 *
-	 * @param string $class Name of the language class
-	 */
-	public static function preloadLanguageClass( $class ) {
-		global $IP;
-
-		if ( $class === 'Language' ) {
-			return;
-		}
-
-		if ( file_exists( "$IP/languages/classes/$class.php" ) ) {
-			include_once "$IP/languages/classes/$class.php";
-		}
-	}
-
 	/**
 	 * Get the LocalisationCache instance
 	 *
@@ -4407,22 +4372,6 @@ class Language {
 		$this->mParentLanguage = false;
 	}
 
-	/**
-	 * Get the name of a file for a certain language code
-	 * @param string $prefix Prepend this to the filename
-	 * @param string $code Language code
-	 * @param string $suffix Append this to the filename
-	 * @throws MWException
-	 * @return string $prefix . $mangledCode . $suffix
-	 */
-	public static function getFileName( $prefix = 'Language', $code, $suffix = '.php' ) {
-		if ( !self::isValidBuiltInCode( $code ) ) {
-			throw new MWException( "Invalid language code \"$code\"" );
-		}
-
-		return $prefix . str_replace( '-', '_', ucfirst( $code ) ) . $suffix;
-	}
-
 	/**
 	 * Get the language code from a file name. Inverse of getFileName()
 	 * @param string $filename $prefix . $languageCode . $suffix
@@ -4440,6 +4389,34 @@ class Language {
 		return str_replace( '_', '-', strtolower( $m[1] ) );
 	}
 
+	/**
+	 * @param string $code
+	 * @return string Name of the language class
+	 */
+	public static function classFromCode( $code ) {
+		if ( $code == 'en' ) {
+			return 'Language';
+		} else {
+			return 'Language' . str_replace( '-', '_', ucfirst( $code ) );
+		}
+	}
+
+	/**
+	 * Get the name of a file for a certain language code
+	 * @param string $prefix Prepend this to the filename
+	 * @param string $code Language code
+	 * @param string $suffix Append this to the filename
+	 * @throws MWException
+	 * @return string $prefix . $mangledCode . $suffix
+	 */
+	public static function getFileName( $prefix = 'Language', $code, $suffix = '.php' ) {
+		if ( !self::isValidBuiltInCode( $code ) ) {
+			throw new MWException( "Invalid language code \"$code\"" );
+		}
+
+		return $prefix . str_replace( '-', '_', ucfirst( $code ) ) . $suffix;
+	}
+
 	/**
 	 * @param string $code
 	 * @return string
@@ -4466,15 +4443,6 @@ class Language {
 		return "$IP/languages/i18n/$code.json";
 	}
 
-	/**
-	 * @param string $code
-	 * @return string
-	 */
-	public static function getClassFileName( $code ) {
-		global $IP;
-		return self::getFileName( "$IP/languages/classes/Language", $code, '.php' );
-	}
-
 	/**
 	 * Get the first fallback for a given language.
 	 *
-- 
2.20.1